test: add ddc factory Ginkgo coverage

pkg/ddc/factory.go

@@ -83,7 +83,7 @@ func InferEngineImpl(runtimeStatus fluidv1alpha1.RuntimeStatus, defaultImpl stri
 
 	// e.g. <dataset_name>-<engine_impl>-values, <dataset_name> may contain "-"
 	parts := strings.Split(runtimeStatus.ValueFileConfigmap, "-")
-	if len(parts) >= 3 {
+	if len(parts) >= 3 && parts[len(parts)-1] == "values" {
 		engineImpl := parts[len(parts)-2]
 		if _, exists := buildFuncMap[engineImpl]; exists {
 			return engineImpl

pkg/ddc/factory_test.go

@@ -0,0 +1,232 @@
+/*
+Copyright 2026 The Fluid Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package ddc
+
+import (
+	"context"
+	"fmt"
+
+	fluidv1alpha1 "github.com/fluid-cloudnative/fluid/api/v1alpha1"
+	"github.com/fluid-cloudnative/fluid/pkg/common"
+	"github.com/fluid-cloudnative/fluid/pkg/dataoperation"
+	"github.com/fluid-cloudnative/fluid/pkg/ddc/base"
+	cruntime "github.com/fluid-cloudnative/fluid/pkg/runtime"
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+	"k8s.io/apimachinery/pkg/types"
+	ctrl "sigs.k8s.io/controller-runtime"
+)
+
+type fakeEngine struct {
+	id string
+}
+
+func (f *fakeEngine) ID() string {
+	return f.id
+}
+
+func (f *fakeEngine) Shutdown() error {
+	return nil
+}
+
+func (f *fakeEngine) Setup(ctx cruntime.ReconcileRequestContext) (bool, error) {
+	return false, nil
+}
+
+func (f *fakeEngine) CreateVolume(ctx context.Context) error {
+	return nil
+}
+
+func (f *fakeEngine) DeleteVolume(ctx context.Context) error {
+	return nil
+}
+
+func (f *fakeEngine) Sync(ctx cruntime.ReconcileRequestContext) error {
+	return nil
+}
+
+func (f *fakeEngine) Validate(ctx cruntime.ReconcileRequestContext) error {
+	return nil
+}
+
+func (f *fakeEngine) Operate(ctx cruntime.ReconcileRequestContext, opStatus *fluidv1alpha1.OperationStatus, operation dataoperation.OperationInterface) (ctrl.Result, error) {
+	return ctrl.Result{}, nil
+}
+
+var _ = Describe("factory", func() {
+	Describe("CreateEngine", func() {
+		It("dispatches using the engine impl and forwards id and context", func() {
+			expectedEngine := &fakeEngine{id: "engine-id"}
+			ctx := cruntime.ReconcileRequestContext{EngineImpl: common.AlluxioEngineImpl}
+			originalBuildFunc, existed := buildFuncMap[common.AlluxioEngineImpl]
+			captured := struct {
+				id  string
+				ctx cruntime.ReconcileRequestContext
+			}{}
+			DeferCleanup(func() {
+				if existed {
+					buildFuncMap[common.AlluxioEngineImpl] = originalBuildFunc
+				} else {
+					delete(buildFuncMap, common.AlluxioEngineImpl)
+				}
+			})
+
+			buildFuncMap[common.AlluxioEngineImpl] = func(id string, gotCtx cruntime.ReconcileRequestContext) (base.Engine, error) {
+				captured.id = id
+				captured.ctx = gotCtx
+				return expectedEngine, nil
+			}
+
+			engine, err := CreateEngine("engine-id", ctx)
+
+			Expect(err).NotTo(HaveOccurred())
+			Expect(engine).To(BeIdenticalTo(expectedEngine))
+			Expect(captured.id).To(Equal("engine-id"))
+			Expect(captured.ctx).To(Equal(ctx))
+		})
+
+		It("returns builder errors unchanged", func() {
+			expectedErr := fmt.Errorf("builder failed")
+			ctx := cruntime.ReconcileRequestContext{EngineImpl: common.JindoFSEngineImpl}
+			originalBuildFunc, existed := buildFuncMap[common.JindoFSEngineImpl]
+			DeferCleanup(func() {
+				if existed {
+					buildFuncMap[common.JindoFSEngineImpl] = originalBuildFunc
+				} else {
+					delete(buildFuncMap, common.JindoFSEngineImpl)
+				}
+			})
+
+			buildFuncMap[common.JindoFSEngineImpl] = func(id string, gotCtx cruntime.ReconcileRequestContext) (base.Engine, error) {
+				return nil, expectedErr
+			}
+
+			engine, err := CreateEngine("engine-id", ctx)
+
+			Expect(engine).To(BeNil())
+			Expect(err).To(MatchError(expectedErr))
+		})
+
+		It("keeps unrelated engine registrations available during CreateEngine specs", func() {
+			Expect(buildFuncMap).To(HaveKey(common.GooseFSEngineImpl))
+		})
+
+		It("errors on unknown impl and mentions it", func() {
+			ctx := cruntime.ReconcileRequestContext{EngineImpl: "mystery"}
+
+			engine, err := CreateEngine("engine-id", ctx)
+
+			Expect(engine).To(BeNil())
+			Expect(err).To(HaveOccurred())
+			Expect(err.Error()).To(ContainSubstring("mystery"))
+		})
+	})
+
+	Describe("GenerateEngineID", func() {
+		It("returns namespace-name", func() {
+			id := GenerateEngineID(types.NamespacedName{Namespace: "fluid", Name: "demo"})
+
+			Expect(id).To(Equal("fluid-demo"))
+		})
+	})
+
+	Describe("InferEngineImpl", func() {
+		It("returns default for empty value file configmap", func() {
+			impl := InferEngineImpl(fluidv1alpha1.RuntimeStatus{}, common.ThinEngineImpl)
+
+			Expect(impl).To(Equal(common.ThinEngineImpl))
+		})
+
+		It("returns the recognized engine from dataset-engine-values", func() {
+			impl := InferEngineImpl(fluidv1alpha1.RuntimeStatus{ValueFileConfigmap: "dataset-goosefs-values"}, common.ThinEngineImpl)
+
+			Expect(impl).To(Equal(common.GooseFSEngineImpl))
+		})
+
+		It("still works when the dataset name contains hyphens", func() {
+			impl := InferEngineImpl(fluidv1alpha1.RuntimeStatus{ValueFileConfigmap: "my-dataset-jindocache-values"}, common.ThinEngineImpl)
+
+			Expect(impl).To(Equal(common.JindoCacheEngineImpl))
+		})
+
+		It("still works when the dataset name itself contains values", func() {
+			impl := InferEngineImpl(fluidv1alpha1.RuntimeStatus{ValueFileConfigmap: "my-values-dataset-goosefs-values"}, common.ThinEngineImpl)
+
+			Expect(impl).To(Equal(common.GooseFSEngineImpl))
+		})
+
+		It("falls back to default for malformed configmap names", func() {
+			impl := InferEngineImpl(fluidv1alpha1.RuntimeStatus{ValueFileConfigmap: "dataset-alluxio-config"}, common.ThinEngineImpl)
+
+			Expect(impl).To(Equal(common.ThinEngineImpl))
+		})
+
+		It("falls back to default when only a non-values suffix contains a registered engine", func() {
+			impl := InferEngineImpl(fluidv1alpha1.RuntimeStatus{ValueFileConfigmap: "dataset-values-alluxio-config"}, common.ThinEngineImpl)
+
+			Expect(impl).To(Equal(common.ThinEngineImpl))
+		})
+
+		It("falls back to default for unrecognized engines", func() {
+			impl := InferEngineImpl(fluidv1alpha1.RuntimeStatus{ValueFileConfigmap: "dataset-unknown-values"}, common.ThinEngineImpl)
+
+			Expect(impl).To(Equal(common.ThinEngineImpl))
+		})
+	})
+
+	Describe("buildFuncMap", func() {
+		It("registers the expected engines", func() {
+			expectedEngines := []string{
+				common.AlluxioEngineImpl,
+				common.JindoFSEngineImpl,
+				common.JindoFSxEngineImpl,
+				common.JindoCacheEngineImpl,
+				common.GooseFSEngineImpl,
+				common.JuiceFSEngineImpl,
+				common.ThinEngineImpl,
+				common.EFCEngineImpl,
+				common.VineyardEngineImpl,
+				common.CacheEngineImpl,
+			}
+
+			Expect(buildFuncMap).To(HaveLen(len(expectedEngines)))
+			for _, engine := range expectedEngines {
+				Expect(buildFuncMap).To(HaveKey(engine))
+			}
+		})
+
+		It("uses canonical dataset-engine-values names for every registered engine", func() {
+			expectedEngines := []string{
+				common.AlluxioEngineImpl,
+				common.JindoFSEngineImpl,
+				common.JindoFSxEngineImpl,
+				common.JindoCacheEngineImpl,
+				common.GooseFSEngineImpl,
+				common.JuiceFSEngineImpl,
+				common.ThinEngineImpl,
+				common.EFCEngineImpl,
+				common.VineyardEngineImpl,
+				common.CacheEngineImpl,
+			}
+
+			for _, engine := range expectedEngines {
+				configmapName := fmt.Sprintf("dataset-%s-values", engine)
+				Expect(InferEngineImpl(fluidv1alpha1.RuntimeStatus{ValueFileConfigmap: configmapName}, common.ThinEngineImpl)).To(Equal(engine))
+			}
+		})
+	})
+})

pkg/ddc/suite_test.go

@@ -0,0 +1,29 @@
+/*
+Copyright 2026 The Fluid Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package ddc
+
+import (
+	"testing"
+
+	. "github.com/onsi/ginkgo/v2"
+	. "github.com/onsi/gomega"
+)
+
+func TestDDC(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "DDC Suite", Label("ddc"))
+}