Extend CacheRuntime phase 2 BUG FIX: ufs path empty#5833
Extend CacheRuntime phase 2 BUG FIX: ufs path empty#5833xliuqq wants to merge 1 commit intofluid-cloudnative:masterfrom
Conversation
Signed-off-by: xliuqq <xlzq1992@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
There was a problem hiding this comment.
Code Review
This pull request updates the UFS path generation logic in pkg/ddc/cache/engine/cm.go to use GenUFSPathInUnifiedNamespace and modifies a test configuration in test/gha-e2e/curvine/dataset.yaml by commenting out a path entry. Feedback was provided to remove a misleading comment in the Go code that incorrectly implies the path generation logic only handles empty paths, as the function itself is more robust.
| // m.Path is empty, use /{m.Name} | ||
| Path: utils.UFSPathBuilder{}.GenUFSPathInUnifiedNamespace(m), |
There was a problem hiding this comment.
The comment added here is slightly misleading because GenUFSPathInUnifiedNamespace handles both cases: it uses the provided path if it is absolute, and defaults to /{m.Name} otherwise. The comment implies it only handles the empty case. Since the function name is already descriptive of its purpose, the comment is redundant and could be confusing if a path is actually provided. I suggest removing it to keep the code clean.
| // m.Path is empty, use /{m.Name} | |
| Path: utils.UFSPathBuilder{}.GenUFSPathInUnifiedNamespace(m), | |
| Path: utils.UFSPathBuilder{}.GenUFSPathInUnifiedNamespace(m), |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5833 +/- ##
==========================================
- Coverage 58.94% 58.93% -0.01%
==========================================
Files 479 479
Lines 32443 32444 +1
==========================================
Hits 19122 19122
- Misses 11772 11773 +1
Partials 1549 1549 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|



Ⅰ. Describe what this PR does
use GenUFSPathInUnifiedNamespace when Dataset Mount Path field is empty.
Ⅱ. Does this pull request fix one issue?
part of #5412
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews