Skip to content

Add /go/video-player-drm design doc redirect#13154

Merged
sfshaza2 merged 2 commits intoflutter:mainfrom
nateshmbhat:patch-2
Mar 9, 2026
Merged

Add /go/video-player-drm design doc redirect#13154
sfshaza2 merged 2 commits intoflutter:mainfrom
nateshmbhat:patch-2

Conversation

@nateshmbhat
Copy link
Contributor

Description

Adds a flutter.dev/go redirect for the DRM support design document for video_player.

The new go link points to the public design doc covering proposed first-party DRM support for:

  • Android Widevine
  • iOS FairPlay

This is needed so the design doc follows the Flutter design doc process and can be referenced from the tracking issue and review discussions.

Related Issues

Testing

  • Verified the redirect entry was added in the expected location.
  • Verified the destination URL points to the public Google Doc.

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

Added a new design doc
@nateshmbhat nateshmbhat requested review from a team and sfshaza2 as code owners March 6, 2026 07:51
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new redirect entry in the firebase.json configuration. This redirect facilitates access to the design document outlining proposed first-party DRM support for Android Widevine and iOS FairPlay within the video_player plugin, ensuring it aligns with the Flutter design document process and can be easily referenced.

Highlights

  • New Redirect Added: A /go/video-player-drm redirect has been added to firebase.json, pointing to the public design document for DRM support in the video_player plugin.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • firebase.json
    • Added a new redirect rule for /go/video-player-drm to a Google Docs link.
Activity
  • No human activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a redirect for the video_player DRM support design document. I've reviewed the change and found one minor issue regarding the alphabetical ordering of redirects in firebase.json. Please see my comment for details on where to place the new entry to maintain consistency.

Note: Security Review has been skipped due to the limited scope of the PR.

@parlough
Copy link
Member

parlough commented Mar 8, 2026

/gcbrun

@parlough parlough changed the title Update firebase.json Add /go/video-player-drm design doc redirect Mar 8, 2026
@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit f2c3f68):

https://flutter-docs-prod--pr13154-patch-2-ibr7x3m8.web.app

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfshaza2 sfshaza2 merged commit 4c17ebc into flutter:main Mar 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants