Add RsyncCommandSender class to replace execnet rsync calls#512
Draft
Add RsyncCommandSender class to replace execnet rsync calls#512
Conversation
Member
Author
|
Git bundle is sadly not yet tested properly in the tests, I believe due to us not having a ssh server at our disposal, as such the new code is not yet run in the tests |
Member
Author
|
Maybe this calls for a nixos test for batou, perhaps building on top of https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/openssh.nix |
…t logic in rsyncgit integration test
…place-files service
…ment configuration
…ment configuration and add file checks in integration tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For git and mercurial bundle this time specifically