Update CreateRun to call UploadInputs first#899
Merged
Conversation
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pingsutw
reviewed
Apr 3, 2026
Comment on lines
+392
to
+396
|
|
||
| upload_req = dataproxy_service_pb2.UploadInputsRequest( | ||
| inputs=inputs.proto_inputs, | ||
| ) | ||
| if run_id is not None: |
Member
There was a problem hiding this comment.
qq: why can't we use dataproxy to get the signed url here and upload data here?
Contributor
Author
There was a problem hiding this comment.
resolved offline, we want to compute the inputs hash on the server side for consistency across clients
pingsutw
previously approved these changes
Apr 3, 2026
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pingsutw
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for secure environments
DO NOT MERGE: until API & BE changes land in OSS (flyte repo)