fix(sandbox-bundled): Use a yaml string for FLYTE_PLATFORM_INSECURE#7079
Open
honnix wants to merge 4 commits intoflyteorg:masterfrom
Open
fix(sandbox-bundled): Use a yaml string for FLYTE_PLATFORM_INSECURE#7079honnix wants to merge 4 commits intoflyteorg:masterfrom
honnix wants to merge 4 commits intoflyteorg:masterfrom
Conversation
Signed-off-by: Honnix <honnix@users.noreply.github.com>
honnix
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7079 +/- ##
=======================================
Coverage 56.95% 56.95%
=======================================
Files 931 931
Lines 58188 58188
=======================================
Hits 33141 33141
Misses 22005 22005
Partials 3042 3042
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8 tasks
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
pingsutw
reviewed
Mar 28, 2026
| - FLYTE_AWS_SECRET_ACCESS_KEY: miniostorage | ||
| - FLYTE_PLATFORM_URL: 'flyte-sandbox-grpc.flyte:8089' | ||
| - FLYTE_PLATFORM_INSECURE: true | ||
| - FLYTE_PLATFORM_INSECURE: 'true' |
Member
There was a problem hiding this comment.
This file is auto generated. should we update this line
flyte/charts/flyte-sandbox/values.yaml
Line 61 in ba331fd
Member
Author
There was a problem hiding this comment.
I guess the string 'True' or 'true' is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
The boolean value seems to be parse incorrectly.
What changes were proposed in this pull request?
Change it to a yaml string value.
How was this patch tested?
Found this when using latest sandbox-bundled image for our integration tests. I had to patch this value to a string to make it work.
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link