fix: adjust name for ActionIdentifier to a fixed value "a0"#7092
Merged
pingsutw merged 4 commits intoflyteorg:v2from Mar 27, 2026
Merged
fix: adjust name for ActionIdentifier to a fixed value "a0"#7092pingsutw merged 4 commits intoflyteorg:v2from
pingsutw merged 4 commits intoflyteorg:v2from
Conversation
fix the duplicated key not allowed issue for adjusting name to fixed value add run_name to unique index idx_actions_identifier add function to drop old index idx_actions_identifier before build new idx_actions_identifier sync action_test.go constraint Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>
…nName New const variable rootActionName to be assign "a0" Remove drop old idx_actions_identifier function Adjust all test function to match name is "a0" Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>
Signed-off-by: SZL741023 <shengzhe.lin@icloud.com>
machichima
reviewed
Mar 27, 2026
| const ( | ||
| runIDLength = 20 | ||
| runStringFormat = "r%s" | ||
| RootActionName = "a0" |
Member
There was a problem hiding this comment.
Can we directly use this in other places rather then re-define rootActionName or use "a0"?
pingsutw
requested changes
Mar 27, 2026
Member
There was a problem hiding this comment.
Update: Ignore it, not related to your PR, sorry.
seeing this error when running the task. https://github.com/flyteorg/flyte-sdk/blob/d1be428f793dd9f9f51f97c0fd677fd43865a5c4/examples/basics/hello.py#L1-L37
Pod failed. No message received from kubernetes.
[rrnx9b8km7bh59x6kpf9-a0-0] terminated with exit code (1). Reason [Error]. Message:
tine)
File "/opt/venv/lib/python3.12/site-packages/flyte/_utils/coro_management.py", line 26, in run_coros
raise err
File "/opt/venv/lib/python3.12/site-packages/flyte/_internal/runtime/entrypoints.py", line 206, in load_and_run_task
task = await _download_and_load_task(code_bundle, resolver, resolver_args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.12/site-packages/flyte/_internal/runtime/entrypoints.py", line 140, in _download_and_load_task
code_bundle = await download_code_bundle(code_bundle)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.12/site-packages/flyte/_internal/runtime/entrypoints.py", line 130, in download_code_bundle
downloaded_path = await download_bundle(code_bundle)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.12/site-packages/flyte/storage/_storage.py", line 227, in get
return await _get_obstore_bypass(from_path, to_path, recursive, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/venv/lib/python3.12/site-packages/flyte/storage/_storage.py", line 191, in _get_obstore_bypass
await reader.download_files(
File "/opt/venv/lib/python3.12/site-packages/flyte/storage/_parallel_reader.py", line 288, in download_files
async for _ in self._as_completed(_gen(temporary_dir), transformer=_transform_decorator(temporary_dir)):
File "/opt/venv/lib/python3.12/site-packages/flyte/storage/_parallel_reader.py", line 197, in _as_completed
async with asyncio.TaskGroup() as tg:
^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/asyncio/taskgroups.py", line 71, in __aexit__
return await self._aexit(et, exc)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/asyncio/taskgroups.py", line 164, in _aexit
raise BaseExceptionGroup(
Filtered traceback (most recent call last):
ExceptionGroup: unhandled errors in a TaskGroup (1 sub-exception)
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
Assign value
"a0"todetails.action.id.name, but it is one of the unique index inidx_action_domain.If this value is fixed, that mean all workflow only can have a run task, so add the
run_nameto be one of the unique index inidx_action_domain.What changes were proposed in this pull request?
Fix the duplicated key not allowed issue for adjusting
details.action.id.nameto fixed valueAdd run_name to unique index
idx_actions_identifier.Add migrate function to drop old index idx_actions_identifier before build new type idx_actions_identifier
Sync
action_test.goconstraintHow was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Test Result
main