Skip to content

[V2] Set global secret if both project and domain not provided#7102

Merged
pingsutw merged 3 commits intov2from
set_global_secret_when_namespace_not_specified
Mar 30, 2026
Merged

[V2] Set global secret if both project and domain not provided#7102
pingsutw merged 3 commits intov2from
set_global_secret_when_namespace_not_specified

Conversation

@popojk
Copy link
Copy Markdown
Contributor

@popojk popojk commented Mar 27, 2026

Tracking issue

n/a

Why are the changes needed?

We should set the secret under sandbox namespace as global secret if secret create without specifying project and domain.

What changes were proposed in this pull request?

Add fallback rule in secret service

How was this patch tested?

  1. Create a secret without project and domain flyte create secret OPENAI_API_KEY --value secret123
  2. We will get the secret in sandbox namespace Screenshot 2026-03-27 at 11 44 42 AM

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

  • main

Signed-off-by: Alex Wu <c.alexwu@gmail.com>
@github-actions github-actions bot mentioned this pull request Mar 27, 2026
3 tasks
popojk added 2 commits March 29, 2026 22:23
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
Signed-off-by: Alex Wu <c.alexwu@gmail.com>
@popojk popojk requested a review from pingsutw March 29, 2026 14:33
@pingsutw pingsutw merged commit b4f37d0 into v2 Mar 30, 2026
17 checks passed
@pingsutw pingsutw deleted the set_global_secret_when_namespace_not_specified branch March 30, 2026 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants