fix: suppress pflag usage output on startup errors#7106
Merged
Conversation
Set SilenceUsage on the root cobra command so that runtime errors (e.g. database connection failures) only print the error message instead of dumping the full flags list. Signed-off-by: Kevin Su <pingsutw@apache.org>
AdilFayyaz
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SilenceUsage: trueon the root cobra command so that runtime errors (e.g. database connection failures) only print the error message instead of dumping the full flags listBefore:
After:
Test plan
Start the binary without a database and confirm only the error is printed (no flags list)
Run with
--helpand confirm usage/flags are still displayedmain