NEW @W-20597715@ Adding changes to support react in .jsx files for single react plugin [Inital PR to review the LLD] #392
+2,495
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namrata111f
changed the title
stephen-carter-at-sf
requested changes
Dec 30, 2025
Comment on lines
+146
to
+147
| // Note: disable_react_base_config is intentionally excluded - React support is gated | ||
| // TODO: Add 'disable_react_base_config' when React support is released |
Contributor
There was a problem hiding this comment.
How can you actually test this then?
Shouldn't you then use the
addKeysThatBypassValidation
method then so that this key (when attempting to use it internally) doesn't throw an error by this check? See https://github.com/forcedotcom/code-analyzer-core/blob/dev/packages/code-analyzer-core/src/config.ts#L145C25-L145C52 for example.
Comment on lines
+68
to
+77
| // Deep clone the languageOptions to avoid mutating the original shared config from the LWC package | ||
| const originalParserOptions = configs[0].languageOptions!.parserOptions as Linter.ParserOptions; | ||
| const clonedBabelOptions = JSON.parse(JSON.stringify(originalParserOptions.babelOptions)); | ||
| configs[0].languageOptions = { | ||
| ...configs[0].languageOptions, | ||
| parserOptions: { | ||
| ...originalParserOptions, | ||
| babelOptions: clonedBabelOptions | ||
| } | ||
| }; |
Contributor
There was a problem hiding this comment.
You shouldn't be needing to do any cloning. Simply reconstruct and override using the {...someObj, someField: { ...someObj.someField, someSubField: xyz }} trick!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.