move session UI state to UiRoot #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Review highlighted UI state stored in SessionState; user requested full refactor to align with architecture rules. Solution: Added SessionViewState and SessionInteractionComponent to own per-session UI interaction state. Rewired input, focus actions, and rendering to use UI-managed view state. Removed UI fields from SessionState and updated UiHost/architecture docs.
There was a problem hiding this comment.
Pull request overview
This PR refactors terminal session UI state management by moving per-session UI interaction state (selection, hover, scrollback, and cursor handling) from SessionState into a new SessionViewState managed by SessionInteractionComponent in UiRoot.
Changes:
- Introduced
SessionViewStateto hold per-session UI state (selection, hover, scrollback, attention) - Created
SessionInteractionComponentto manage view states and handle mouse/scroll/cursor interactions - Removed UI-related fields from
SessionStateand relocated interaction logic frommain.zig
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ui/types.zig | Added terminal sizing and mouse context fields to UiHost, added FocusSession action |
| src/ui/session_view_state.zig | New file defining per-session UI state (selection, hover, scrollback) |
| src/ui/mod.zig | Exported SessionViewState and SessionInteractionComponent |
| src/ui/components/session_interaction.zig | New component handling all terminal mouse/scroll interaction and cursor logic |
| src/session/state.zig | Removed UI fields (status, attention, scrollback, selection, hover, scroll) from SessionState |
| src/render/renderer.zig | Updated to consume SessionViewState for rendering overlays instead of SessionState |
| src/main.zig | Refactored to use SessionInteractionComponent; removed inline mouse/scroll/selection handlers |
| docs/architecture.md | Documented new session view state architecture |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: