Skip to content

Savetxt options#1177

Merged
jvdp1 merged 51 commits intofortran-lang:masterfrom
fiolj:savetxt-options
Apr 7, 2026
Merged

Savetxt options#1177
jvdp1 merged 51 commits intofortran-lang:masterfrom
fiolj:savetxt-options

Conversation

@fiolj
Copy link
Copy Markdown
Contributor

@fiolj fiolj commented Apr 7, 2026

This PR replaces PR #1085 for adding optional arguments to savetxt().
Merge of this PR should close also PR #1085 and issue #1076

fiolj and others added 30 commits December 22, 2025 11:59
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Juan Fiol and others added 21 commits January 30, 2026 16:31
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Added:
- comments with intent of variable `fout`
- stop the program if unit file is not open
- clean-up comments
Added clarification of use with filename and unit.
Also added an example
Co-authored-by: José Alves <102541118+jalvesz@users.noreply.github.com>
Co-authored-by: José Alves <102541118+jalvesz@users.noreply.github.com>
Co-authored-by: José Alves <102541118+jalvesz@users.noreply.github.com>
@fiolj fiolj mentioned this pull request Apr 7, 2026
Copy link
Copy Markdown
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @fiolj (and sorry for all the issues with the other PR). LGTM.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

❌ Patch coverage is 83.95062% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.76%. Comparing base (72698fd) to head (be3494f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
example/io/example_savetxt.f90 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1177      +/-   ##
==========================================
+ Coverage   68.66%   68.76%   +0.10%     
==========================================
  Files         408      408              
  Lines       13619    13697      +78     
  Branches     1537     1543       +6     
==========================================
+ Hits         9351     9419      +68     
- Misses       4268     4278      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jvdp1
Copy link
Copy Markdown
Member

jvdp1 commented Apr 7, 2026

I will merge this PR as it is a clean version of #1085 that has been reviewed extensively and approved. Thank @fiolj for this PR

Closes #1085

@jvdp1 jvdp1 merged commit d30e087 into fortran-lang:master Apr 7, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants