-
Notifications
You must be signed in to change notification settings - Fork 152
fix (cleanup): simplifies “Create Event” page and remove unstable options #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enext
Are you sure you want to change the base?
Conversation
Currently translated at 0.1% (3 of 4121 strings) Translation: eventyay/Eventyay Tickets Translate-URL: https://hosted.weblate.org/projects/open-event/eventyay-tickets/zh_Hant/
Currently translated at 0.2% (9 of 4121 strings) Translation: eventyay/Eventyay Tickets Translate-URL: https://hosted.weblate.org/projects/open-event/eventyay-tickets/zh_Hant/
Currently translated at 0.4% (18 of 4121 strings) Translation: eventyay/Eventyay Tickets Translate-URL: https://hosted.weblate.org/projects/open-event/eventyay-tickets/pl_INFORMAL/
Currently translated at 2.9% (123 of 4121 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/zh_Hant/
Currently translated at 2.9% (123 of 4121 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/zh_Hant/
Reviewer's GuideRemoves unstable component-selection UI from the “Create Event” page and enhances the Class diagram for updated Event initialization logicclassDiagram
class Event {
+build_initial_data()
cfp
schedules
items
score_categories
}
class CfP {
event
default_type
}
class Schedule {
event
}
class ItemCategory {
event
name
}
class Item {
event
name
default_price
category
}
class ReviewScoreCategory {
event
name
}
class ReviewScore {
category
value
label
}
Event --> CfP
Event --> Schedule
Event --> ItemCategory
ItemCategory --> Item
Event --> ReviewScoreCategory
ReviewScoreCategory --> ReviewScore
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The create_foundation.html template is cluttered with large commented-out sections; consider removing dead code or wrapping it behind a feature flag for better maintainability.
- In build_initial_data, use get_or_create for ItemCategory and Item instead of always create to make initialization idempotent and avoid IntegrityErrors on reruns.
- Ensure the automatic ticket setup covers any additional Pretix requirements (like quotas or tax rules) so no essential configurations are missing post-creation.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The create_foundation.html template is cluttered with large commented-out sections; consider removing dead code or wrapping it behind a feature flag for better maintainability.
- In build_initial_data, use get_or_create for ItemCategory and Item instead of always create to make initialization idempotent and avoid IntegrityErrors on reruns.
- Ensure the automatic ticket setup covers any additional Pretix requirements (like quotas or tax rules) so no essential configurations are missing post-creation.
## Individual Comments
### Comment 1
<location> `talk/src/pretalx/event/models/event.py:647-657` </location>
<code_context>
+ # --- New Section: Initialize Tickets system automatically ---
+ from pretix.presale.models import Item, ItemCategory # adjust import if needed
+ if not self.items.exists():
+ category = ItemCategory.objects.create(event=self, name=_("Tickets"))
+ Item.objects.create(
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Check for existing ticket categories/items with more granularity.
Currently, the check does not differentiate between ticket and non-ticket items, which may result in duplicate ticket categories. Please update the logic to specifically check for an existing 'Tickets' category or 'General Admission' item.
```suggestion
# --- New Section: Initialize Tickets system automatically ---
from pretix.presale.models import Item, ItemCategory # adjust import if needed
# Check for existing 'Tickets' category
tickets_category = ItemCategory.objects.filter(event=self, name=_("Tickets")).first()
if not tickets_category:
tickets_category = ItemCategory.objects.create(event=self, name=_("Tickets"))
# Check for existing 'General Admission' item in the 'Tickets' category
general_admission_item = Item.objects.filter(
event=self,
name=_("General Admission"),
category=tickets_category
).first()
if not general_admission_item:
Item.objects.create(
event=self,
name=_("General Admission"),
default_price=0,
category=tickets_category,
)
# ------------------------------------------------------------
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| # --- New Section: Initialize Tickets system automatically --- | ||
| from pretix.presale.models import Item, ItemCategory # adjust import if needed | ||
| if not self.items.exists(): | ||
| category = ItemCategory.objects.create(event=self, name=_("Tickets")) | ||
| Item.objects.create( | ||
| event=self, | ||
| name=_("General Admission"), | ||
| default_price=0, | ||
| category=category, | ||
| ) | ||
| # ------------------------------------------------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Check for existing ticket categories/items with more granularity.
Currently, the check does not differentiate between ticket and non-ticket items, which may result in duplicate ticket categories. Please update the logic to specifically check for an existing 'Tickets' category or 'General Admission' item.
| # --- New Section: Initialize Tickets system automatically --- | |
| from pretix.presale.models import Item, ItemCategory # adjust import if needed | |
| if not self.items.exists(): | |
| category = ItemCategory.objects.create(event=self, name=_("Tickets")) | |
| Item.objects.create( | |
| event=self, | |
| name=_("General Admission"), | |
| default_price=0, | |
| category=category, | |
| ) | |
| # ------------------------------------------------------------ | |
| # --- New Section: Initialize Tickets system automatically --- | |
| from pretix.presale.models import Item, ItemCategory # adjust import if needed | |
| # Check for existing 'Tickets' category | |
| tickets_category = ItemCategory.objects.filter(event=self, name=_("Tickets")).first() | |
| if not tickets_category: | |
| tickets_category = ItemCategory.objects.create(event=self, name=_("Tickets")) | |
| # Check for existing 'General Admission' item in the 'Tickets' category | |
| general_admission_item = Item.objects.filter( | |
| event=self, | |
| name=_("General Admission"), | |
| category=tickets_category | |
| ).first() | |
| if not general_admission_item: | |
| Item.objects.create( | |
| event=self, | |
| name=_("General Admission"), | |
| default_price=0, | |
| category=tickets_category, | |
| ) | |
| # ------------------------------------------------------------ |
|
Please use a descriptive title for the PR. |
The issue was caused by unconditional access to test_form.cleaned_data without checking if the form validation succeeded. When test_form.is_valid() returned False, accessing cleaned_data could raise AttributeError or return incomplete data, causing a 500 error. Solution: Added conditional check to only access cleaned_data when form is valid, otherwise use empty dict for initial values. This ensures the export page loads properly even when no valid GET parameters are provided. Changes: - Modified ExportMixin.exporters property in control/views/orders.py - Added validation check before accessing test_form.cleaned_data - Fallback to empty dict when form is invalid
Applied the same fix from issueto the organizer-level export
functionality. The ExportMixin in organizer.py had the identical issue
where test_form.cleaned_data was accessed without checking if the form
validation succeeded first.
This prevents potential HTTP 500 errors when accessing:
- /control/organizer/{organizer}/export/
Changes:
- Modified ExportMixin.exporters in control/views/organizer.py
- Added validation check before accessing test_form.cleaned_data
- Fallback to empty dict when form is invalid
- Use f-strings instead of string concatenation for better readability - Rename 'id' variable to 'identifier' to avoid shadowing builtin - Apply improvements to both orders.py and organizer.py Addresses Sourcery suggestions...
- Add JSON_FIELD_AVAILABLE setting based on database backend (postgresql = True) - Fix checkinlists exporter using old Event.items instead of Event.products - Resolves AttributeError when accessing export functionality
- Changed from if/else validation check to getattr() to preserve partial cleaned_data - This allows useful defaults even when form is partially invalid - Reverted unnecessary 'id' to 'identifier' rename in organizer.py - Renamed 'items' field to 'products' in checkinlists exporter for consistency - Updated form_data['items'] to form_data['products'] reference
…ponent layout (fossasia#1377) * Move powered by eventyay below content area on Ticket Pages * update email condition * Apply Copilot suggestions * remove contact us --------- Co-authored-by: Mario Behling <[email protected]>
…ossasia#1378) Co-authored-by: Mario Behling <[email protected]>
…1412) * fix(language): Restore language selection to checkbox list * fix(selection): Add fixes to selection
* added template files * cfp * fix: Add options management interface for CFP custom fields * fix: Reorder form fields to match Pretalx * fix: Display Field required radio buttons inline with proper Bootstrap styling --------- Co-authored-by: Mario Behling <[email protected]>
) Currently translated at 95.5% (5278 of 5522 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/de/ Co-authored-by: Andreas Kleinert <[email protected]>
…a#1340) * Add auto-expanding textarea * guard to prevent duplication * inline JS to separate static file and other modifications * initial text area & resize * viewport-size * initial height & scrollbar appears only inside textarea not on page --------- Co-authored-by: Mario Behling <[email protected]>
* add logging * add defaults via migration
* wip * Add drag-and-drop reordering for talk question answer options * Add i18n support and null check for drag-and-drop
* save room fix try and added logging * implemented suggestions --------- Co-authored-by: Mario Behling <[email protected]>
Currently translated at 30.1% (1660 of 5509 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/zh_Hant/
Currently translated at 27.2% (1501 of 5509 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/ko/
Currently translated at 17.7% (977 of 5509 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/ja/
Currently translated at 30.1% (1661 of 5509 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/zh_Hant/
Currently translated at 0.1% (5 of 5509 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/id/
Currently translated at 95.6% (5279 of 5519 strings) Translation: eventyay/eventyay Translate-URL: https://hosted.weblate.org/projects/eventyay/eventyay/de/
i18n(translations): update localized strings from Weblate
…ossasia#1435) Updates the requirements on [sentry-sdk](https://github.com/getsentry/sentry-python) to permit the latest version. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-python@2.46.0...2.47.0) --- updated-dependencies: - dependency-name: sentry-sdk dependency-version: 2.47.0 dependency-type: direct:production ... Signed-off-by: Mario Behling <[email protected]>
Co-authored-by: Mario Behling <[email protected]>
mariobehling
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address AI reviews. Thank you
Remove unstable component selection and ensure initial event data setup (closes #1154)
Summary
This PR removes the unstable component selection UI (Tickets, Talk, Video) from the “Create Event” page and ensures all three components are initialized automatically when a new event is created.
Changes
eventyay/eventyay_common/templates/eventyay_common/events/create_foundation.htmltalk/src/pretalx/event/models/event.py) builds all default components on event creation.Expected Behavior
Screenshots
Before:

After:


TODO (Future)
(closes #1154)
Summary by Sourcery
Remove the component-selection toggles from the event creation template and ensure all event components (Tickets, Talk, Video) are initialized by default during event setup.
Bug Fixes:
Enhancements: