Skip to content

Conversation

@ArnavBallinCode
Copy link
Contributor

@ArnavBallinCode ArnavBallinCode commented Nov 16, 2025

Fix: Hide unpublished sessions from talk component menu

The talk component's left sidebar was displaying Schedule, Sessions, and Speakers menu links even when the schedule had not been officially published. This exposed Work-In-Progress (WIP) session information to attendees before organizers were ready to release it.

Added publication status checks to the talk component's sidebar to hide schedule-related menu items and session information when the schedule has not been officially released.

Fixes #1307

Summary by Sourcery

Hide schedule-related menu items and session details in the talk component until the schedule has been officially published

Bug Fixes:

  • Add publication status checks to the room sidebar to hide Schedule, Sessions, and Speakers links and session information when the schedule is not published
  • Update server-side talk navigation template to only show the Sessions tab if a published or current schedule exists

Enhancements:

  • Introduce hasPublishedSchedule computed property to centralize schedule publication checks

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 16, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Added publication status checks to hide schedule-related menu items and session details until the schedule is officially published.

Class diagram for RoomsSidebar component changes

classDiagram
    class RoomsSidebar {
      +hasPublishedSchedule()
      +computed: roomsByType, schedule, currentSessionPerRoom
      +methods: getDMChannelName()
    }
    RoomsSidebar : hasPublishedSchedule() checks if schedule.version exists
    RoomsSidebar : Only shows schedule-related menu items if hasPublishedSchedule is true
    RoomsSidebar : Only shows session info if hasPublishedSchedule is true
Loading

File-Level Changes

Change Details Files
Conditionally render schedule-related menu links and session details based on publication status
  • Wrapped schedule, sessions, and speakers links with a v-if guard on publication status
  • Updated session information logic to require both feature flag and published status
  • Introduced hasPublishedSchedule computed property to detect schedule.version
app/eventyay/webapp/src/components/RoomsSidebar.vue
Updated fragment navigation template to hide sessions tab when no published schedule exists
  • Adjusted sessions link condition to require a published schedule or current_schedule before rendering
app/eventyay/agenda/templates/agenda/fragment_nav.html

Assessment against linked issues

Issue Objective Addressed Explanation
#1307 Hide session and program items from the Talk Component menu when the schedule/sessions are not published.
#1307 Add conditional checks tied to schedule/session publication flags to control visibility of session information.
#1307 Ensure unpublished sessions cannot be accessed via direct links in the Talk Component menu.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mariobehling
Copy link
Member

Please always provide screenshots or a short video. Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds publication status checks to prevent Work-In-Progress (WIP) session information from being displayed to attendees before the schedule is officially released.

  • Added a hasPublishedSchedule computed property to check if the schedule has been published (has a version)
  • Modified session information display logic to respect schedule publication status
  • Updated server-side navigation template to only show the Sessions tab when a published schedule exists

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/eventyay/webapp/src/components/RoomsSidebar.vue Added hasPublishedSchedule computed property and applied it to conditionally hide session information in the rooms sidebar when schedule is not published
app/eventyay/agenda/templates/agenda/fragment_nav.html Added schedule publication check to Sessions tab visibility condition to prevent displaying the tab when no published schedule exists

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mariobehling mariobehling changed the title Fix: Hide unpublished sessions from talk component menu #1307 Fix: Hide unpublished sessions from talk component menu Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session information appears in Talk Component menu even when schedule/sessions are unpublished

2 participants