-
Notifications
You must be signed in to change notification settings - Fork 134
Fix: Hide unpublished sessions from talk component menu #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enext
Are you sure you want to change the base?
Fix: Hide unpublished sessions from talk component menu #1318
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdded publication status checks to hide schedule-related menu items and session details until the schedule is officially published. Class diagram for RoomsSidebar component changesclassDiagram
class RoomsSidebar {
+hasPublishedSchedule()
+computed: roomsByType, schedule, currentSessionPerRoom
+methods: getDMChannelName()
}
RoomsSidebar : hasPublishedSchedule() checks if schedule.version exists
RoomsSidebar : Only shows schedule-related menu items if hasPublishedSchedule is true
RoomsSidebar : Only shows session info if hasPublishedSchedule is true
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Please always provide screenshots or a short video. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds publication status checks to prevent Work-In-Progress (WIP) session information from being displayed to attendees before the schedule is officially released.
- Added a
hasPublishedSchedulecomputed property to check if the schedule has been published (has a version) - Modified session information display logic to respect schedule publication status
- Updated server-side navigation template to only show the Sessions tab when a published schedule exists
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/eventyay/webapp/src/components/RoomsSidebar.vue | Added hasPublishedSchedule computed property and applied it to conditionally hide session information in the rooms sidebar when schedule is not published |
| app/eventyay/agenda/templates/agenda/fragment_nav.html | Added schedule publication check to Sessions tab visibility condition to prevent displaying the tab when no published schedule exists |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix: Hide unpublished sessions from talk component menu
The talk component's left sidebar was displaying Schedule, Sessions, and Speakers menu links even when the schedule had not been officially published. This exposed Work-In-Progress (WIP) session information to attendees before organizers were ready to release it.
Added publication status checks to the talk component's sidebar to hide schedule-related menu items and session information when the schedule has not been officially released.
Fixes #1307
Summary by Sourcery
Hide schedule-related menu items and session details in the talk component until the schedule has been officially published
Bug Fixes:
Enhancements: