Skip to content

Conversation

@Saksham-Sirohi
Copy link
Contributor

@Saksham-Sirohi Saksham-Sirohi commented Nov 28, 2025

Fixes this problem: Previously https://next.eventyay.com/{eventslug}/ should be -> https://next.eventyay.com/{orgname}/{eventslug}/talk

Summary by Sourcery

New Features:

  • Expose a new /talk route for events that renders the event start page under the updated URL scheme.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 28, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a new /talk endpoint under the main domain event routing that serves the event start page, ensuring event URLs include the organizer segment and /talk suffix, and wires it to the existing EventStartpage view.

Sequence diagram for resolving the new event talk endpoint

sequenceDiagram
    actor User
    participant Browser
    participant DjangoMainDomainURLconf
    participant EventStartpage

    User->>Browser: Enter URL /{orgname}/{eventslug}/talk
    Browser->>DjangoMainDomainURLconf: HTTP GET /{orgname}/{eventslug}/talk
    DjangoMainDomainURLconf->>DjangoMainDomainURLconf: Match re_path ^talk/?$
    DjangoMainDomainURLconf->>EventStartpage: Dispatch request to as_view
    EventStartpage-->>DjangoMainDomainURLconf: Rendered event start page response
    DjangoMainDomainURLconf-->>Browser: HTTP 200 HTML
    Browser-->>User: Display event talk start page
Loading

Flow diagram for Django routing to the new talk endpoint

flowchart LR
    A["HTTP GET /{orgname}/{eventslug}/talk"] --> B[Django main domain URLconf]
    B --> C[Locale and organizer specific patterns]
    C --> D[Match re_path ^talk/?$ name event.talk]
    D --> E[EventStartpage.as_view]
    E --> F[Render event start page response]
    F --> G[Return HTTP response to client]
Loading

File-Level Changes

Change Details Files
Expose a dedicated /talk route for events mapped to the EventStartpage view within the main domain URL configuration.
  • Import EventStartpage view from eventyay.cfp.views.event into the main domain URL configuration module.
  • Register a new re_path for the talk endpoint (r'^talk/?$') pointing to EventStartpage.as_view() with the URL name 'event.talk' within the event-specific URL patterns.
app/eventyay/multidomain/maindomain_urlconf.py

Possibly linked issues

  • #(not specified): PR adds the Talk endpoint routing needed for the unified {orgname}/{eventslug}/talk schema described in the issue.

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider using path('talk/', EventStartpage.as_view(), ...) instead of re_path(r'^talk/?$'...) for consistency with the rest of the URL patterns unless there is a specific need for regex here.
  • Double-check that mounting EventStartpage at /talk picks up the correct event context in the multidomain setup (org + event slug) and doesn’t rely on URL parts that are no longer present at this level.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider using `path('talk/', EventStartpage.as_view(), ...)` instead of `re_path(r'^talk/?$'...)` for consistency with the rest of the URL patterns unless there is a specific need for regex here.
- Double-check that mounting `EventStartpage` at `/talk` picks up the correct event context in the multidomain setup (org + event slug) and doesn’t rely on URL parts that are no longer present at this level.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mariobehling mariobehling merged commit 4d3509a into fossasia:enext Nov 28, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Eventyay Next Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants