Always match routes against percent-encoded paths.#78
Merged
tigerwill90 merged 2 commits intomasterfrom Feb 14, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
pawndev
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route matching previously relied on
url.URL.RawPathfor the request path, falling back tourl.URL.PathwhenRawPathwas empty. The problem is that Go only populatesRawPathfor certain encoded characters like%2F. A path like/cafégets decoded intourl.URL.Pathas/caféwithRawPathleft empty. This meant matching behavior was inconsistent depending on which characters happened to be encoded in the request.This switches to
url.URL.EscapedPath(), which always returns the closest representation to the raw request line. Matching now consistently operates on percent-encoded paths regardless of what characters are encoded. Hex digits in percent-encoding are normalized to uppercase (%c3%a9→%C3%A9) to ensure equivalent encodings match the same route.All routing entry points (
ServeHTTP,Match,Lookup, andSub) now use a sharedroutingPath()helper instead of callingc.Path()directly. This function callsEscapedPath()and normalizes any lowercase hex digits to uppercase whenRawPathis set:When
RawPathis empty,EscapedPath()already produces uppercase hex, so normalization is skipped.