Realtime inbox badge updates — decrement unread count when notifications are marked read#415
Closed
SachinSingh008 wants to merge 1 commit into
Closed
Realtime inbox badge updates — decrement unread count when notifications are marked read#415SachinSingh008 wants to merge 1 commit into
SachinSingh008 wants to merge 1 commit into
Conversation
Contributor
|
Fixed in #478 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Realtime inbox badge updates — decrement unread count when notifications are marked read
Summary
Unread notification count in the sidebar did not decrement after opening/marking a notification as read until a full page reload. This adds a realtime refetch on notification updates so the count updates immediately.
Changes
on_updatetoGPNotificationto publishrefetch_resourceforUnread Notifications Countwhenreadchanges (with a safe fallback whenreadis set).Rationale
after_insert, but marking as read had no corresponding event. Emitting a refetch on read state change keeps the badge accurate without reloads.Testing
Notes
refetch_resourceand reloadsUnread Notifications Count, so no UI changes were needed.