Conversation
|
@replydev is attempting to deploy a commit to the freemanjiang's projects Team on Vercel. A member of the Team first needs to authorize it. |
05b5bfa to
d113299
Compare
d113299 to
a263df3
Compare
|
Looks promising! Will take a look tomorrow. However, I'm not sure about catalogue and search with Dab Music. I may hold off on this in favour of exploring a proper YouTube/Spotify integration. |
|
Thanks for commenting @freeman-jiang, I see that Dab Music may not be the best provider since it is almost unknown. I made this almost for my self since I use it everyday and provides quality (FLAC) tracks, so please consider merging it, and later on maybe provide other implementations based on YT, Spotify, Deezer ot anything else... |
|
Anyway I guess dab music connects to Deezer or other similar services since it has access, again, to quality data and not compressed mp3 like YT (not YT Music I guess) |
|
Hey thanks for putting this up! This is actually pretty good. Search and download works well. There are some UX issues I would work on, such as not being able to search by pressing enter. The main thing is I'm not sure how reliable or consistent the API with dab music is. Would users ever get rate-limited? |
|
So, I agree on UX improvements, I also pressed enter during development and was disappointed it didn't work, but forgot to add it finally. I guess we have not any info about the Dab Music API stability, neither rate limiting for sure. Another big risk, is that your main instance could be overwhelmed of download requests, so implementing a rate limit or something else on your side would be required. I want to make clear that I designed this mostly for myself and my friend, since we will use it in our server, so we do not have rate limit, DoS attack or similar issues. |
|
Oh, and regarding the duplicated tracks, this is what the Dab Music API replies, I guess they came from different sources. We could try some sort of post processing, deduplicating and giving the priority to the track that has the highest quality. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
460cb54 to
55222e7
Compare
|
@replydev For a potential rate-limits solution we could just download from the client, and then upload that data to the server as we would with a normal file, right? |
|
@MalTeeez from a certain prospective, this could be more safer, but I am not
@MalTeeez from a certain prospective your idea could be safer, but I am not sure I would like it, because in this way we are capped by the client network. It's so much faster using the server directly. I guess it's a trade-off between safety and functionality. I would try to explore more solutions but always open to discussions 👍 . |


This PR implements search and download feature from Dab Music, without leaving the main dashboard.
I made two abstractions, so it should be easy to adapt it to other providers if needed.
Improvement points: