Skip to content

Dab Music Implementation#18

Open
replydev wants to merge 13 commits intofreeman-jiang:mainfrom
replydev:feat/dab-music-integration
Open

Dab Music Implementation#18
replydev wants to merge 13 commits intofreeman-jiang:mainfrom
replydev:feat/dab-music-integration

Conversation

@replydev
Copy link

@replydev replydev commented Apr 30, 2025

This PR implements search and download feature from Dab Music, without leaving the main dashboard.
I made two abstractions, so it should be easy to adapt it to other providers if needed.

Improvement points:

  • Make the API URL configurable
  • Modal UI may be less ugly

@vercel
Copy link

vercel bot commented Apr 30, 2025

@replydev is attempting to deploy a commit to the freemanjiang's projects Team on Vercel.

A member of the Team first needs to authorize it.

@replydev replydev force-pushed the feat/dab-music-integration branch from 05b5bfa to d113299 Compare April 30, 2025 23:52
@replydev replydev force-pushed the feat/dab-music-integration branch from d113299 to a263df3 Compare April 30, 2025 23:53
@freeman-jiang
Copy link
Owner

Looks promising! Will take a look tomorrow.

However, I'm not sure about catalogue and search with Dab Music. I may hold off on this in favour of exploring a proper YouTube/Spotify integration.

@replydev
Copy link
Author

replydev commented May 1, 2025

Thanks for commenting @freeman-jiang, I see that Dab Music may not be the best provider since it is almost unknown.

I made this almost for my self since I use it everyday and provides quality (FLAC) tracks, so please consider merging it, and later on maybe provide other implementations based on YT, Spotify, Deezer ot anything else...

@replydev
Copy link
Author

replydev commented May 1, 2025

Anyway I guess dab music connects to Deezer or other similar services since it has access, again, to quality data and not compressed mp3 like YT (not YT Music I guess)

@freeman-jiang
Copy link
Owner

Hey thanks for putting this up! This is actually pretty good. Search and download works well. There are some UX issues I would work on, such as not being able to search by pressing enter.

The main thing is I'm not sure how reliable or consistent the API with dab music is. Would users ever get rate-limited?

And search is duplicated here:
image

@replydev
Copy link
Author

replydev commented May 2, 2025

So, I agree on UX improvements, I also pressed enter during development and was disappointed it didn't work, but forgot to add it finally.

I guess we have not any info about the Dab Music API stability, neither rate limiting for sure.

Another big risk, is that your main instance could be overwhelmed of download requests, so implementing a rate limit or something else on your side would be required.

I want to make clear that I designed this mostly for myself and my friend, since we will use it in our server, so we do not have rate limit, DoS attack or similar issues.

@replydev
Copy link
Author

replydev commented May 2, 2025

Oh, and regarding the duplicated tracks, this is what the Dab Music API replies, I guess they came from different sources. We could try some sort of post processing, deduplicating and giving the priority to the track that has the highest quality.

@MalTeeez
Copy link

MalTeeez commented May 3, 2025

I made some experimental changes, not sure if this fits the idea:
image

@replydev
Copy link
Author

replydev commented May 3, 2025

I made some experimental changes, not sure if this fits the idea:
image

For sure this kind of UI refinements was needed 👍

@vercel
Copy link

vercel bot commented May 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beatsync ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2025 8:56pm

@replydev replydev force-pushed the feat/dab-music-integration branch from 460cb54 to 55222e7 Compare May 5, 2025 16:08
@MalTeeez
Copy link

MalTeeez commented May 7, 2025

@replydev For a potential rate-limits solution we could just download from the client, and then upload that data to the server as we would with a normal file, right?

@replydev
Copy link
Author

replydev commented May 8, 2025

@MalTeeez from a certain prospective, this could be more safer, but I am not

@replydev For a potential rate-limits solution we could just download from the client, and then upload that data to the server as we would with a normal file, right?

@MalTeeez from a certain prospective your idea could be safer, but I am not sure I would like it, because in this way we are capped by the client network.

It's so much faster using the server directly. I guess it's a trade-off between safety and functionality.

I would try to explore more solutions but always open to discussions 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants