feat: add QR code for room join#26
feat: add QR code for room join#26ShubhamSPawade wants to merge 5 commits intofreeman-jiang:mainfrom
Conversation
|
@ShubhamSPawade is attempting to deploy a commit to the freemanjiang's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi! @freeman-jiang 👋, Just wanted to follow up on this PR. QR code joining is a small but powerful feature that really improves the multi-device experience. Would love to get your thoughts — I believe it's a must-have for seamless syncing. Thanks! |
|
@ShubhamSPawade looks awesome, could you maybe switch the url with one derived from the providers url, i.e. just from window.location.href to support multiple instances. |
|
Hey! @MalTeeez My first PR should totally get merged in 😅 — it's a small addition but really improves multi-device syncing. I’ll update the QR code to use window.location.origin instead of the hardcoded URL so it supports self-hosted instances too. Will push that shortly! |
freeman-jiang
left a comment
There was a problem hiding this comment.
Good effort, but needs a lot more polish before it's ready.
|
@freeman-jiang done with the changes.. please take a review |
|
|
Please resolve conflicts and merge with main, would also be good if you can include an updated screenshot. |
Adds a QR code modal to share the room URL for easier multi-device joining.
https://www.beatsync.gg/room/<roomId>)Benefits : Enables fast, error-free room joining across devices