Add AbortSignal.any() IDL entry and corresponding tests#92
Open
vardhan30016 wants to merge 1 commit intofreeman-jiang:mainfrom
Open
Add AbortSignal.any() IDL entry and corresponding tests#92vardhan30016 wants to merge 1 commit intofreeman-jiang:mainfrom
vardhan30016 wants to merge 1 commit intofreeman-jiang:mainfrom
Conversation
|
@vardhan30016 is attempting to deploy a commit to the freemanjiang's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi @freeman-jiang 👋 Just following up on this PR — please let me know if any changes are needed. Happy to update anything you’d like. Thanks for maintaining this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the missing
AbortSignal.any()static method to the Web IDL definitionsand introduces basic tests to verify correct behavior according to the specification.
Changes
interfaces/dom.idlto include:static AbortSignal any(sequence<AbortSignal> signals);dom/abort/abort-signal-any.any.jsAbortSignal.any()returns a new AbortSignalTypeErroris thrown when invalid items are passedWhy
The
AbortSignal.any()method exists in the spec and in browser implementations,but the Web Platform Tests repo did not yet include IDL coverage or functional tests.
This PR brings WPT closer to spec completeness.
Notes