wifi: mt76: mt76x02: wake queues after reconfig #3621
Merged
+54
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocktrron
force-pushed
the
mt76-wake-on-reconfig
branch
from
de42848 to
45fdcaf
Compare
The shared reset procedure of MT7610 and MT7612 stop all queues before starting the reset sequence. They however never restart these like other supported mt76 chips do in the reconfig_complete call. This leads to TX not continuing after the reset. Restart queues in the reconfig_complete callback to restore functionality after the reset. Signed-off-by: David Bauer <[email protected]> Link: https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
blocktrron
force-pushed
the
mt76-wake-on-reconfig
branch
from
45fdcaf to
08ed069
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue i have observed for a longer time but never got around to bisect.
Looking at the graph, you can see memory usage filling up and the device subsequently reboot:
This is the same for the crashes within short intervals (additionally with high client-load):
I'll send the patch upstream, but i appreciate feedback as quite some popular devices from the lower-end (Netgear R6120 / Archer C50 / Xiaomi MiRouter 4AG) are affected.
The shared reset procedure of MT7610 and MT7612 stop all queues before starting the reset sequence but never restartet these like other supported mt76 chips do in the reconfig_complete call.
This leads to TX not continuing after the reset.
Restart queues in the reconfig_complete callback to restore functionality after the reset.