Add 'fix' command to apply fixes (and unit test) by webwarrior-ws · Pull Request #754 · fsprojects/FSharpLint

webwarrior-ws · 2025-07-28T12:02:31Z

Also removed FromText property of SuggestedFix as it duplicates FromRange functionality and is not actually used anywhere.

src/FSharpLint.Core/Text.resx

src/FSharpLint.Console/Program.fs

knocte · 2025-07-29T10:20:07Z

src/FSharpLint.Console/Program.fs

+
+    let handleFixResult (ruleName: string) = function
+        | LintResult.Success warnings ->
+            String.Format(Resources.GetString "ConsoleApplyingSuggestedFixFile", ruleName) |> output.WriteInfo


@webwarrior-ws ruleName? this is wrong

What should the parameter be then?

Same as what happens when printing "Linting {0}", obviously

Changed to print notification for every warning, with file name as parameter. There may be several warnings per file though.

There may be several warnings per file though.

Then this was wrong, it should only print once per file. (And it was also wrong even if not adding the $0 element.)

Because I guess that "Linting {0}" only gets printed once per file/project/solution?

The function is not called once per file, but once per rule.

I'm not talking about what the code does now, but what the code should do. And it should do the same as Linting{0}

Changed the logic. Now it is what you meant @knocte ?

knocte · 2025-08-13T10:17:03Z

@webwarrior-ws let's rebase this PR when you have time (but beware of recent push from me, to include the last commit; so git pull --rebase first please)

knocte · 2025-08-13T21:29:14Z

@webwarrior-ws sorry this needs another rebase

webwarrior-ws · 2025-08-14T10:27:27Z

@webwarrior-ws sorry this needs another rebase

Rebased

knocte · 2026-01-06T04:39:05Z

I'm going to remove commit c0a3ab1 from this PR because I moved that change to PR793.

knocte · 2026-01-06T10:36:12Z

src/FSharpLint.Console/Program.fs

    else
        FileType.Source

+// can't extract inner functions because they modify exitCode variable


@webwarrior-ws this reason shouldn't apply anymore after I merged PR813 in master, so let's rebase and double check

(this PR should now introduce a new function that doesn't use a mutable exitCode var, AFAIU)

Refactored code to not use mutable exitCode and extracted inner functions.

I didn't ask you to remove mutable var from existing lint() function; what I said is that the new function that should be implemented (in this case, applySuggestedFix), should not use a mutable exitCode. Also:

why did you rename lint() to applyLint()? doesn't seem necessary at all

a function named "linting()"? function names should use infinitive, not gerund

These names are probably not from me. But I changed applyLint back to lint and linting to performlinting.

performlinting? man, that's neither PascalCase nor camelCase, what notation is that?

Actual name in the source is performLinting.

src/FSharpLint.Console/Program.fs

knocte · 2026-01-06T14:39:39Z

src/FSharpLint.Console/Program.fs

+        output.WriteError $"Lint failed while analysing %s{target}.{Environment.NewLine}Failed with: %s{exn.Message}{Environment.NewLine}Stack trace: {exn.StackTrace}"
+        ExitCode.Failure
+
+let private lint (lintArgs: ParseResults<LintArgs>) (output: Output.IOutput) (toolsPath:Ionide.ProjInfo.Types.ToolsPath) : ExitCode =


@webwarrior-ws the previous version of this func had each param in its own line, why break that formatting?

Made each pram be on its own line.

Removed FromText property of SuggestedFix as it duplicates FromRange functionality and is not actually used anywhere.

Co-authored-by: Parham Saremi <[email protected]> Co-authored-by: webwarrior-ws <[email protected]>

webwarrior-ws closed this Jul 28, 2025

webwarrior-ws force-pushed the remove-suggestedfix-fromtext branch from a583792 to 3924085 Compare July 28, 2025 12:03

webwarrior-ws reopened this Jul 28, 2025

webwarrior-ws force-pushed the remove-suggestedfix-fromtext branch 3 times, most recently from 3c64772 to 7880339 Compare July 28, 2025 13:22

webwarrior-ws changed the title ~~Core(Framework,Rules): SuggestedFix refactoring~~ Add fix command-line to apply quickfixes and unit test Jul 28, 2025

webwarrior-ws force-pushed the remove-suggestedfix-fromtext branch 3 times, most recently from 14a265e to 27342d3 Compare July 29, 2025 08:43