Improvements to 'create' CLI command: rename type arg and add error handling#72
Merged
martindurant merged 2 commits intofsspec:mainfrom Mar 19, 2026
Merged
Conversation
- Rename the `type` argument to `spec_type` to avoid shadowing the Python builtin. - Validate the spec type against the registry before attempting creation, and catch NotImplementedError to print a helpful list of which types actually support creation.
src/projspec/__main__.py
Outdated
|
|
||
| @main.command("create") | ||
| @click.argument("type") | ||
| @click.argument("spec_type") |
Member
There was a problem hiding this comment.
Elsewhere in the CLI< this is called "types". Should that become "spec_types"?
Member
|
Since we are doing this, should the info path (function call and CLI) be changed to indicate which of the classes support create()? That way, the frontend can show only relevant types. |
Member
|
@ktaletsk , I reverted to "type", and the info JSON output now contains a "create": true|false field for each spec type. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
type→spec_type(avoids shadowing the Python builtin)