Skip to content

Conversation

@hartfordfive
Copy link
Contributor

@hartfordfive hartfordfive commented Sep 6, 2020

Here's the Kafka tailer integration as discussed in the other stale PR. Please note I've also vendored in all the related dependencies.

@hartfordfive hartfordfive force-pushed the kafka-tailer-integration branch from 72deb83 to 107c43e Compare September 6, 2020 22:23
@coveralls
Copy link

coveralls commented Sep 6, 2020

Coverage Status

Coverage decreased (-3.0%) to 62.151% when pulling d9ee0b3 on hartfordfive:kafka-tailer-integration into 6d86abe on fstab:master.

@fstab
Copy link
Owner

fstab commented Sep 7, 2020

Thanks a lot! I don't think it's necessary to add the vendor/ directory, because go.mod and go.sum already contain all required information for reproducible builds, and you can always generate the vendor/ directory with go mod vendor. Please remove it.

@hartfordfive
Copy link
Contributor Author

@fstab I've gone ahead and deleted the vendor directory.

As a bit of context for you, I've encountered situations in the past where a repo was no longer available or moved, which was very problematic. Consequently, this is why I often vendor my dependencies so there is always a guarantee I can rebuild a given version with only the application repo. In some cases, certain industries may have requirements to store the source code of opensource projects used (especially if they are complementing some other proprietary software) in case of a future audit, for example, trading firms in the finance industry.

I hope this provides a bit of clarity as to why I initially did this!

@fstab fstab merged commit 9d10852 into fstab:master Sep 8, 2020
@fstab
Copy link
Owner

fstab commented Sep 8, 2020

Thanks a lot! I merged it. I will make a release soon.

Your comments on reproducible builds make sense. However, I'm not sure if committing all dependencies to the source repository is the best solution. Maybe I should provide a vendor source tar with each release or something like that.

@hartfordfive
Copy link
Contributor Author

Yes, having a separate build that would also include the vendor build sounds like a great idea to me.

@fstab
Copy link
Owner

fstab commented Sep 21, 2020

I thought again about adding the vendor/ folder for making builds reproducible. I think you are right. I added the vendor/ folder with 1.0.0.RC5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants