Update PublishCodeCoverage to v2

[dan-hughes]

Pull Request

Pull Request (PR) description

Update PublishCodeCoverage in azure-pipelines to v2. This is already validated in WSManDsc.

• Fixes Publish code coverage' version 1 (PublishCodeCoverageResults@1) is deprecated #551.

Task list

• The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
• Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
• Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency).
• Documentation added/updated in README.md.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[dan-hughes]

@johlju @gaelcolas, can someone trigger CI please.

[johlju]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[johlju]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[johlju]

Maybe third time is the charm, seems there is an issue with the gallery.

[johlju]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[johlju]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[johlju]

@gaelcolas there are intermittent error (connection issues) from PS Gallery, shall we skip those tests for PowerShellGet for now as the goal is to move to PSResourceGet (you mentioned you worked on it)?

[johlju]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[johlju]

Now this fails with the same problem as in Sampler.GitHubTasks, so there is an issue with upstream somehow.

[johlju]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[dan-hughes]

@johlju, again please?

[johlju]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[dan-hughes]

@johlju, @gaelcolas, pick through this,

It works, but maybe not as intended.

PSResourceGet 1.0.1 looks to be completely unusable/broken, there must have been a backend PSGallery change that this does not like.

Using PSResourceGet latest 1.1.1, seems to have a bug which rears it's head when looking to package Plaster, which on version 1.1.4 contains two psd1 files in the root of the module both starting with the ModuleName.

Additionally PSResourceGet 1.1.1 seems to pull in a Plaster pre-release version labelled 2.0.0-alpha1 due to Sampler declaring Plaster as a required module in it's manifest. It could be due to the same bug of not being able to determine the valid module manifest.

Seemingly, using PSResourceGet 1.2.0-rc3 fixes all of these issues...

[johlju]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[johlju]

Great work @dan-hughes

So if 1.2.0-rc3 solves this, we should wait for 1.2.0 to be released so we don't have to pin an rc version?

[dan-hughes]

Or don't do a full release? I wonder if Sampler.GitHubTasks was the same issue.

I'll let you both decide what to do.

[dan-hughes]

@johlju, PSResourceGet released 1.2.0. PR updated.

[gaelcolas]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[gaelcolas]

that looks good to me.
Lets see if it passes the tests before merging.