Skip to content

Fix variable definition in pf_active mapping#403

Merged
torrinba merged 2 commits intomasterfrom
fix_d3d_pf_active_mapping
Apr 14, 2026
Merged

Fix variable definition in pf_active mapping#403
torrinba merged 2 commits intomasterfrom
fix_d3d_pf_active_mapping

Conversation

@torrinba
Copy link
Copy Markdown
Collaborator

@torrinba torrinba commented Apr 8, 2026

Description

The current data in the shaping coils was not actually being provided as expected by the IMAS DD.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Other (please describe):

Testing

Comparison with imas_composer

Pre-Merge Checklist

  • OMFIT has been tested with this OMAS version and you will create a PR on OMFIT that updates the OMAS submodule once this has been merged.
  • Version number has been incremented if this is a major modification or important bug fix
    • To increment the version: Edit the version number in omas/version file
    • Follow semantic versioning: MAJOR.MINOR.PATCH (e.g., 0.94.20.94.3 for bug fixes, 0.94.20.95.0 for new features)
    • A GitHub release will be automatically created when this PR is merged if the version number has changed

The current data in the shaping coils was not actually being
provided as expected by the IMAS DD.
Copy link
Copy Markdown
Collaborator

@AreWeDreaming AreWeDreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This corrects a typo.

@AreWeDreaming
Copy link
Copy Markdown
Collaborator

@torrinba Please increment the version of OMAS as indicated above. Then feel free to merge.

@torrinba torrinba merged commit 1fb78c1 into master Apr 14, 2026
8 checks passed
@torrinba torrinba deleted the fix_d3d_pf_active_mapping branch April 14, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants