Skip to content

Conversation

@dimityrmirchev
Copy link
Member

What this PR does / why we need it:
/kind ehnancement
/area audit-logging

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/cc @vpnachev

Release note:

NONE

@dimityrmirchev dimityrmirchev requested a review from a team as a code owner January 9, 2026 08:48
@gardener-robot gardener-robot added the area/audit-logging Audit logging related label Jan 9, 2026
@gardener-robot
Copy link

@dimityrmirchev Label kind/ehnancement does not exist.

@gardener-robot gardener-robot added the needs/review Needs review label Jan 9, 2026
@gardener-github-actions gardener-github-actions bot added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 9, 2026
@gardener-robot gardener-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2026
@dimityrmirchev
Copy link
Member Author

/kind enhancement

@github-actions github-actions bot added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 9, 2026
@gardener-robot gardener-robot added the kind/enhancement Enhancement, improvement, extension label Jan 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

🧹 Preview Removed

The preview for this PR is no longer available since the PR has been closed.

title: Kubernetes Auditing
description: Gardener extension controller which deploys an auditlog forwarder sending Kubernetes Audit Events to configured backends.
source: https://github.com/gardener/gardener-extension-auditing/blob/main/README.md
- fileTree: https://github.com/gardener/gardener-extension-auditing/tree/main/docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want the api-reference and development folders to be also added on the website? I think other components are somehow filtering out some of their docs/ folder content to not be shown on the website.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add to what @vpnachev said, what do you want the final structure of the new section to look like? Adding the content like this would add the entire contents of the development and usage folders to the newly created Kubernetes Auditing section, apart from auditing, which will have its own folder:
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that all extensions filter out the dev folder. See https://gardener.cloud/docs/extensions/others/gardener-extension-registry-cache/getting-started-locally/. It shows when the the dev persona is selected.

The api-reference folder is also useful especially when not all configuration options are explicitly mentioned in an usage.md file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @vpnachev and @n-boshnakov,

Can we proceed with this PR or should I address something? From my point of view the PR looks good the way it is.

Copy link
Contributor

@n-boshnakov n-boshnakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@n-boshnakov n-boshnakov merged commit 509ec18 into gardener:master Jan 20, 2026
11 checks passed
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026
@gardener-prow
Copy link

gardener-prow bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n-boshnakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow
Copy link

gardener-prow bot commented Jan 20, 2026

LGTM label has been added.

DetailsGit tree hash: ae4c8a273efd85d43c5ad7f24a9d99cd1436dc24

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit-logging Audit logging related kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants