Skip to content

effective-creation-timeout & new metrics for use by dependency-watchdog#1104

Draft
elankath wants to merge 4 commits into
gardener:masterfrom
elankath:timeout-metrics
Draft

effective-creation-timeout & new metrics for use by dependency-watchdog#1104
elankath wants to merge 4 commits into
gardener:masterfrom
elankath:timeout-metrics

Conversation

@elankath
Copy link
Copy Markdown
Member

@elankath elankath commented May 26, 2026

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1103
Fixes #1098

Special notes for your reviewer:

Release note:

Support node.machine.sapcloud.io/effective-creation-timeout on MachineDeployment to override shoot configured machineControllerManager.machineCreationTimeout for use by dependency-watchdog

Support new metrics: machine_create_duration_seconds, machine_initialize_duration_seconds, machine_join_duration_seconds,machine_drain_duration_seconds,machine_delete_duration_seconds,

@elankath elankath self-assigned this May 26, 2026
@elankath elankath requested a review from a team as a code owner May 26, 2026 18:45
@gardener-prow gardener-prow Bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 26, 2026
@elankath elankath marked this pull request as draft May 26, 2026 18:45
@gardener-prow gardener-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 26, 2026
@gardener-prow
Copy link
Copy Markdown

gardener-prow Bot commented May 26, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from elankath. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

1 participant