fix: setup runs pending migrations so git pull + ./setup works#774
Merged
fix: setup runs pending migrations so git pull + ./setup works#774
Conversation
Previously, version migrations only ran during /gstack-upgrade (Step 4.75). Users who updated via git pull + ./setup never got migrations applied, leaving stale skill directory structures in place. Now setup tracks the last-run version in ~/.gstack/.last-setup-version and runs any pending migrations automatically. Idempotent — safe to run multiple times. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Previously, version migrations only ran during /gstack-upgrade (Step 4.75). Users who updated via git pull + ./setup never got migrations applied, leaving stale skill directory structures in place. Now setup tracks the last-run version in ~/.gstack/.last-setup-version and runs any pending migrations automatically. Addresses adversarial review findings: space-safe while-read loop, fresh install guard, upper-bound version check, missing VERSION guard.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
E2E Evals: ✅ PASS0/0 tests passed | $0 total cost | 12 parallel runners
12x ubicloud-standard-2 (Docker: pre-baked toolchain + deps) | wall clock ≈ slowest suite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git pull && ./setupnow applies version migrations automatically. Previously, migrations only ran during/gstack-upgrade(Step 4.75 of the upgrade skill). Users who updated gstack viagit pull + ./setupnever got state fixes applied, leaving stale skill directory structures in place (e.g., the v0.15.2.0 migration that fixes unprefixed skill directories never ran).What changed:
setupnow tracks the last version it ran at in~/.gstack/.last-setup-versiongstack-upgrade/migrations/while readloop instead offorto handle paths with spacesPre-Landing Review
No issues found.
Adversarial Review
Claude adversarial subagent found 6 findings. All FIXABLE items addressed:
Test plan
🤖 Generated with Claude Code