Show unreachable, enabled peers #2987
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ON93754
reviewed
Dec 3, 2025
frontend/src/common/ChipSelector.tsx
Outdated
| | { | ||
| multiple: true | ||
| options: string[] | ||
| options: [string, boolean][] | string[] |
Member
There was a problem hiding this comment.
Is this worth a dedicated type? Looks like it's used elsewhere
type ChipOption = [string, boolean][] | string[];
Member
Author
There was a problem hiding this comment.
Changed type so slightly redundant, but taken advise and given type name so it its use is more intuitive
Bumps the mui-stack group in /lib/landing with 2 updates: [@mui/icons-material](https://github.com/mui/material-ui/tree/HEAD/packages/mui-icons-material) and [@mui/material](https://github.com/mui/material-ui/tree/HEAD/packages/mui-material). Updates `@mui/icons-material` from 6.4.8 to 7.3.5 - [Release notes](https://github.com/mui/material-ui/releases) - [Changelog](https://github.com/mui/material-ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui/material-ui/commits/v7.3.5/packages/mui-icons-material) Updates `@mui/material` from 6.4.8 to 7.3.5 - [Release notes](https://github.com/mui/material-ui/releases) - [Changelog](https://github.com/mui/material-ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui/material-ui/commits/v7.3.5/packages/mui-material) --- updated-dependencies: - dependency-name: "@mui/icons-material" dependency-version: 7.3.5 dependency-type: direct:production update-type: version-update:semver-major dependency-group: mui-stack - dependency-name: "@mui/material" dependency-version: 7.3.5 dependency-type: direct:production update-type: version-update:semver-major dependency-group: mui-stack ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [express](https://github.com/expressjs/express) from 5.1.0 to 5.2.1. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@v5.1.0...v5.2.1) --- updated-dependencies: - dependency-name: express dependency-version: 5.2.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [mdast-util-to-hast](https://github.com/syntax-tree/mdast-util-to-hast) from 13.2.0 to 13.2.1. - [Release notes](https://github.com/syntax-tree/mdast-util-to-hast/releases) - [Commits](syntax-tree/mdast-util-to-hast@13.2.0...13.2.1) --- updated-dependencies: - dependency-name: mdast-util-to-hast dependency-version: 13.2.1 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the react-stack group with 3 updates in the /frontend directory: [@next/mdx](https://github.com/vercel/next.js/tree/HEAD/packages/next-mdx), [next](https://github.com/vercel/next.js) and [@next/bundle-analyzer](https://github.com/vercel/next.js/tree/HEAD/packages/next-bundle-analyzer). Updates `@next/mdx` from 16.0.3 to 16.0.6 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](https://github.com/vercel/next.js/commits/v16.0.6/packages/next-mdx) Updates `next` from 15.5.2 to 16.0.6 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](vercel/next.js@v15.5.2...v16.0.6) Updates `@next/bundle-analyzer` from 15.5.6 to 16.0.6 - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](https://github.com/vercel/next.js/commits/v16.0.6/packages/next-bundle-analyzer) --- updated-dependencies: - dependency-name: "@next/mdx" dependency-version: 16.0.6 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: react-stack - dependency-name: next dependency-version: 16.0.6 dependency-type: direct:production update-type: version-update:semver-major dependency-group: react-stack - dependency-name: "@next/bundle-analyzer" dependency-version: 16.0.6 dependency-type: direct:development update-type: version-update:semver-major dependency-group: react-stack ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [mjml](https://github.com/mjmlio/mjml/tree/HEAD/packages/mjml) from 5.0.0-alpha.6 to 5.0.0-alpha.8. - [Release notes](https://github.com/mjmlio/mjml/releases) - [Commits](https://github.com/mjmlio/mjml/commits/v5.0.0-alpha.8/packages/mjml) --- updated-dependencies: - dependency-name: mjml dependency-version: 5.0.0-alpha.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
ARADDCC002
requested changes
Dec 4, 2025
| return Array.from(peers.entries()) | ||
| .filter(([, value]) => isEnabled(value)) | ||
| .map(([key, value]) => ({ key, value: isReachable(value) })) | ||
| .filter(([, value]) => isEnabled(value) && !isReachable(value)) |
Member
There was a problem hiding this comment.
minor, but I think we should change it to [_key, value]. Seems more readable to me personally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.