Skip to content

ci: add automated binary builds for sails-cli#1218

Merged
m62624 merged 13 commits intomaster-idl-v2from
feat/cargo-dist
Feb 26, 2026
Merged

ci: add automated binary builds for sails-cli#1218
m62624 merged 13 commits intomaster-idl-v2from
feat/cargo-dist

Conversation

@m62624
Copy link
Member

@m62624 m62624 commented Feb 25, 2026

Resolves #570

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @m62624, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the binary build process for sails-cli using the cargo-dist tool. It introduces a new configuration file (dist-workspace.toml) to manage distribution settings and updates dependencies in Cargo.toml to support vendored versions of libgit2 and openssl. This change streamlines the release process and makes the CLI more accessible to users on various platforms.

Highlights

  • Automated Binary Builds: This PR introduces automated binary builds for the sails-cli using cargo-dist, enabling easier distribution and installation for users.
  • Configuration for Distribution: A new dist-workspace.toml file is added to configure the distribution process, including target platforms, installers, and other settings.
  • Dependency Updates: The Cargo.toml file is updated to include vendored-libgit2 and vendored-openssl features for cargo-generate, and a new profile.dist is added for optimized builds.
Changelog
  • Cargo.lock
    • Updated dependencies, including adding openssl and related packages.
  • Cargo.toml
    • Enabled vendored-libgit2 and vendored-openssl features for cargo-generate.
    • Added a profile.dist for optimized builds.
  • dist-workspace.toml
    • Added a new file to configure the distribution process using cargo-dist.
  • rs/cli/Cargo.toml
    • Enabled distribution for the sails-cli package.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/rs-publish.yml
    • .github/workflows/rs-release.yml
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces cargo-dist to automate the creation of binary builds for sails-cli, which is a valuable addition for continuous integration and distribution. The changes correctly enable vendored dependencies for cargo-generate to improve portability and add a dist profile for release builds. The new dist-workspace.toml file configures the build process for multiple targets. I've included one suggestion to improve the cargo-dist workspace configuration for better clarity and to align with best practices.

@m62624 m62624 marked this pull request as ready for review February 26, 2026 07:25
@m62624 m62624 requested a review from vobradovich February 26, 2026 07:26
@m62624 m62624 merged commit 2725ee2 into master-idl-v2 Feb 26, 2026
4 checks passed
@m62624 m62624 deleted the feat/cargo-dist branch February 26, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants