chore(testapps): updates to dev-u-gallery and modelGarden usage#5246
Open
MichaelDoyle wants to merge 1 commit intomainfrom
Open
chore(testapps): updates to dev-u-gallery and modelGarden usage#5246MichaelDoyle wants to merge 1 commit intomainfrom
MichaelDoyle wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several core dependencies, including firebase-admin, firebase-functions, and typescript, and refactors Vertex AI Model Garden usage to use the vertexModelGarden plugin with simplified configurations. It also introduces additional evaluation metrics to the dev-ui-gallery test application and configures rootDir in multiple tsconfig.json files. Feedback identifies a potential runtime error due to misconfigured JSONATA and REGEX metrics, notes an unused dependency in the dev-ui-gallery package, and questions the validity of non-standard version numbers for cross-env and typescript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.