-
Notifications
You must be signed in to change notification settings - Fork 730
feat(js): add init data support to client and express handler #5247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pavelgj
wants to merge
26
commits into
pj/bidi-actions
Choose a base branch
from
pj/init-transport
base: pj/bidi-actions
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a88dfa0
feat(js): added support for bidi actions and flows
pavelgj 993de97
fixed flow typing
pavelgj d00b98c
inputStream from input
pavelgj ad309ae
fix
pavelgj 626da82
jsdocs
pavelgj 8412545
jsdocs
pavelgj 94969a7
docs: Add JSDoc comments to various action and flow types and functions.
pavelgj f520be1
feedback
pavelgj 07da46b
moved defineBidiFlow to beta
pavelgj 6f183a7
feat: Unify action configuration by integrating `Init` parameters dir…
pavelgj 37a8796
refactor: simplify `init` option assignment and remove unnecessary ty…
pavelgj 3c9bcb9
refactor: remove redundant type assertions for `ActionRunOptions` in …
pavelgj 0abe3e2
Merge branch 'main' into pj/bidi-actions
pavelgj 40dce0d
Merge branch 'main' into pj/bidi-actions
pavelgj 3f70493
refactor: streamline bidi action API
pavelgj c3cbb4e
fmt
pavelgj 47abe12
cleanup
pavelgj 531cdc9
refactor: separate BidiActionRunOptions from ActionRunOptions and str…
pavelgj 6857c73
feat: add initialization schema support to actions and improve stream…
pavelgj abbd9de
fix: update channel termination condition to correctly handle falsy v…
pavelgj 3b6e02a
implemented reflection
pavelgj 26998c2
feat: add `init` parameter to runAction for session initialization
pavelgj 83f92e6
fmt
pavelgj eb7f2cb
feat: add init data support to client and express handler
pavelgj 4f92ccd
Merge branch 'pj/bidi-actions' into pj/init-transport
pavelgj 0ea3108
Merge branch 'pj/bidi-actions' into pj/init-transport
pavelgj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
Actiontype parameter for context should use the genericCinstead ofany. This ensures that the action is compatible with the context provided by thecontextProvider. Usinganyhere bypasses type checking for context compatibility, which could lead to runtime errors if the action expects a specific context type that the provider does not supply. Stricter type validation is preferred in this repository to ensure consistency and safety.References