Refactored repeated code into lambda functions for readability. #6782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
approved these changes
Nov 19, 2025
arnoldkk13
force-pushed
the
solve_stokes_lambda_refactor
branch
from
3110ee8 to
38f1d44
Compare
bangerth
reviewed
Nov 20, 2025
Contributor
bangerth
left a comment
bangerth
left a comment
There was a problem hiding this comment.
Yes, nice -- that makes the code less repetitive!
source/simulator/solver_schemes.cc
Outdated
Comment on lines
551
to
557
| auto recompute_rhs = [&]() | ||
| { | ||
| dcr.velocity_residual = system_rhs.block(velocity_block_index).l2_norm(); | ||
| dcr.pressure_residual = system_rhs.block(pressure_block_index).l2_norm(); | ||
| dcr.residual = std::sqrt(dcr.velocity_residual * dcr.velocity_residual + | ||
| dcr.pressure_residual * dcr.pressure_residual); | ||
| }; |
Contributor
There was a problem hiding this comment.
I think this isn't quite the right name for the lambda. You're not actually computing right hand sides, just taking norms. Perhaps call it update_residuals?
arnoldkk13
force-pushed
the
solve_stokes_lambda_refactor
branch
from
38f1d44 to
aae3c92
Compare
gassmoeller
approved these changes
Nov 21, 2025
Member
gassmoeller
left a comment
gassmoeller
left a comment
There was a problem hiding this comment.
Looks all good to me. I will start the testers, but if they succeed this should be ready to merge.
Member
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored some code in the function do_one_defect_correction_Stokes_step to enhance readability. This includes refactoring repeated, small sections of code into lambda functions.
[X ] I have followed the instructions for indenting my code.
[X ] I have tested my new feature locally to ensure it is correct.