Skip to content

fix: error log when failing to request delete lightning address endpoint#2338

Merged
rolznz merged 1 commit into
masterfrom
fix/delete-lightning-address-log
May 23, 2026
Merged

fix: error log when failing to request delete lightning address endpoint#2338
rolznz merged 1 commit into
masterfrom
fix/delete-lightning-address-log

Conversation

@rolznz
Copy link
Copy Markdown
Member

@rolznz rolznz commented May 13, 2026

Summary by CodeRabbit

  • Style
    • Improved clarity of error message displayed when lightning address deletion request fails.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 17d2f32c-2f98-4f78-9923-a4c7945586e7

📥 Commits

Reviewing files that changed from the base of the PR and between 1629653 and fee3ab1.

📒 Files selected for processing (1)
  • alby/alby_oauth_service.go

📝 Walkthrough

Walkthrough

The error log message in the DeleteLightningAddress function's HTTP request failure path was updated to more accurately reflect that the failure occurred during the request phase rather than during the deletion operation itself.

Changes

Error Message Clarification

Layer / File(s) Summary
DeleteLightningAddress error message
alby/alby_oauth_service.go
Error log message clarified from "Failed to delete lightning address endpoint" to "Failed to request delete lightning address endpoint" to distinguish request failure from deletion failure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A message refined, once cloudy, now clear—
The request, not deletion, the source of the fear.
One line improved, precision takes flight,
Debugging logs now tell what went right.
🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the specific fix: updating the error log message when the delete lightning address endpoint request fails.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/delete-lightning-address-log

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rolznz rolznz merged commit 3bb3661 into master May 23, 2026
12 checks passed
@rolznz rolznz deleted the fix/delete-lightning-address-log branch May 23, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant