chore: address feedback on currency input field#2371
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review from @stackingsaunter - we don't want a duplicated BTC on left/right. |
* feat: add BTC denomination toggle to currency input * fix: auto switch decimal bitcoin input to BTC * chore: address feedback on currency input field (#2371) * chore: address feedback on currency input field * feat: make currency input units clickable * fix: separate currency and unit click targets * fix: remove persistent unit toggle highlight * fix: tighten currency input unit spacing * fix: make alternate bitcoin amount clickable * fix: align context amount unit spacing --------- Co-authored-by: saunter <68239231+stackingsaunter@users.noreply.github.com> --------- Co-authored-by: Roland <33993199+rolznz@users.noreply.github.com>
* feat: use currency input in swap flows * feat: add BTC denomination toggle to currency input (#2367) * feat: add BTC denomination toggle to currency input * fix: auto switch decimal bitcoin input to BTC * chore: address feedback on currency input field (#2371) * chore: address feedback on currency input field * feat: make currency input units clickable * fix: separate currency and unit click targets * fix: remove persistent unit toggle highlight * fix: tighten currency input unit spacing * fix: make alternate bitcoin amount clickable * fix: align context amount unit spacing --------- Co-authored-by: saunter <68239231+stackingsaunter@users.noreply.github.com> --------- Co-authored-by: Roland <33993199+rolznz@users.noreply.github.com> --------- Co-authored-by: Roland <33993199+rolznz@users.noreply.github.com>
* feat: use currency input in send flows * feat: use currency input in swap flows (#2322) * feat: use currency input in swap flows * feat: add BTC denomination toggle to currency input (#2367) * feat: add BTC denomination toggle to currency input * fix: auto switch decimal bitcoin input to BTC * chore: address feedback on currency input field (#2371) * chore: address feedback on currency input field * feat: make currency input units clickable * fix: separate currency and unit click targets * fix: remove persistent unit toggle highlight * fix: tighten currency input unit spacing * fix: make alternate bitcoin amount clickable * fix: align context amount unit spacing --------- Co-authored-by: saunter <68239231+stackingsaunter@users.noreply.github.com> --------- Co-authored-by: Roland <33993199+rolznz@users.noreply.github.com> --------- Co-authored-by: Roland <33993199+rolznz@users.noreply.github.com> --------- Co-authored-by: Roland <33993199+rolznz@users.noreply.github.com>
* feat: add currency input to receive flows * feat: use currency input in send flows (#2321) * feat: use currency input in send flows * feat: use currency input in swap flows (#2322) * feat: use currency input in swap flows * feat: add BTC denomination toggle to currency input (#2367) * feat: add BTC denomination toggle to currency input * fix: auto switch decimal bitcoin input to BTC * chore: address feedback on currency input field (#2371) * chore: address feedback on currency input field * feat: make currency input units clickable * fix: separate currency and unit click targets * fix: remove persistent unit toggle highlight * fix: tighten currency input unit spacing * fix: make alternate bitcoin amount clickable * fix: align context amount unit spacing --------- Co-authored-by: saunter <68239231+stackingsaunter@users.noreply.github.com> --------- Co-authored-by: Roland <33993199+rolznz@users.noreply.github.com> --------- Co-authored-by: Roland <33993199+rolznz@users.noreply.github.com> --------- Co-authored-by: Roland <33993199+rolznz@users.noreply.github.com> * fix: tab highlight on currency input field buttons * fix: undo incorrect copy change * chore: undo unrelated change * fix: limit min/max validation to 2 decimal places * fix: input max amounts and context rows based on whether node has channel management * fix: rename spending balance to lightning balance * fix: rename spending balance to lightning balance * fix: re-add anchor reserve alert to swap page * fix: remove autocomplete from currency input field * fix: number of decimals in getModeBound * fix: remove important tailwind modifier --------- Co-authored-by: Roland <33993199+rolznz@users.noreply.github.com> Co-authored-by: Roland Bewick <roland.bewick@gmail.com>
border and focus ring (focus only highlights the input).
global [data-slot="field"] rule.
"₿", "BTC", or fiat symbol).
vertical stripes).
unit (₿ for BIP-177, otherwise sats) when sats is active.