Skip to content

Conversation

@NicoHood
Copy link
Contributor

fix #441

@NicoHood
Copy link
Contributor Author

NicoHood commented Dec 1, 2020

@rhukster Hey Andy, you have recently fixed some of the form template bugs, would you mind also having a look at this one? The linked issue has more details.


{% block label %}
{% endblock %}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would approve this if you didn't remove the label block. It does no harm if not used, and might be being used by users with an extend

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhukster I am not sure if that would make sense. Since we are disabling the whole block, it cannot be displayed anyways. So even when extending the block (for whatever reason) it wont be displayed. Correct me, if I am wrong.

https://github.com/getgrav/grav-plugin-form/blob/develop/templates/forms/layouts/field.html.twig#L4-L20

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need more time to review this, but need to get a release out.. so will leave this one here until I can check it with the other label related PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Checkbox has extra padding because of invisible, duplicated label

2 participants