Skip to content

Conversation

@philprime
Copy link
Member

@philprime philprime commented Oct 31, 2025

This PR contains a document and work-in-progress files from prototyping alternative masking approaches.

We are only going to merge the document develop-docs/VIEW_MASKING_STRATEGIES.md and all other files are just for context.

Please only review the document

#skip-changelog

Closes #6861

@philprime philprime self-assigned this Oct 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 97b936c

@codecov
Copy link

codecov bot commented Oct 31, 2025

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@philprime philprime force-pushed the philprime/masking-dev-docs branch 2 times, most recently from 83b0f8c to c887b99 Compare October 31, 2025 13:36
@philprime philprime force-pushed the philprime/masking-dev-docs branch from c887b99 to c73f441 Compare October 31, 2025 13:44
@philprime
Copy link
Member Author

philprime commented Nov 5, 2025

Also consider these approaches:

  • Defensive-programming approach, masking everything unless there is a 100% certainty an area can be unmasked safely (safest but most complicated approach)
  • Rebuilding a wireframe using colored rectangles based on the view hierarchy, without calling draw methods (should also result in performance improvement)
  • Draw the view into a PDF context, then use PDF manipulation to remove all images (probably not possible because the rendered view is an image by itself)

@philprime philprime marked this pull request as ready for review November 17, 2025 09:02
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great summary

@philprime philprime force-pushed the philprime/masking-dev-docs branch 2 times, most recently from 58f367c to 106f332 Compare November 20, 2025 16:25
@philprime philprime enabled auto-merge (squash) November 20, 2025 16:25
@philprime philprime added the ready-to-merge Use this label to trigger all PR workflows label Nov 20, 2025
@philprime philprime force-pushed the philprime/masking-dev-docs branch from 106f332 to 97b936c Compare November 20, 2025 16:27
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@philprime philprime merged commit ce038db into main Nov 21, 2025
125 checks passed
@philprime philprime deleted the philprime/masking-dev-docs branch November 21, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(develop-docs): Add alternative masking strategies

4 participants