Skip to content

Conversation

@itaybre
Copy link
Contributor

@itaybre itaybre commented Nov 14, 2025

Adds customization to error messages in user feedback.

Closes: #4720

Closes #6824

@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a9b1479

@codecov
Copy link

codecov bot commented Nov 17, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
3967 2 3965 25
View the top 2 failed test(s) by shortest run time
iOS_Swift_UITests.UserFeedbackUITests::testSubmitWithNoFieldsFilledAllRequired
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UserFeedbackUITests.swift:444 - XCTAssertTrue failed
iOS_Swift_UITests.UserFeedbackUITests::testSubmitWithNoFieldsFilledEmailAndMessageRequired
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UserFeedbackUITests.swift:417 - XCTAssertTrue failed

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@itaybre itaybre added the ready-to-merge Use this label to trigger all PR workflows label Nov 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.25 ms 1260.19 ms 33.94 ms
Size 24.15 KiB 1.02 MiB 1016.05 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ee1f2ca 1227.47 ms 1251.58 ms 24.12 ms
0759f32 1237.10 ms 1257.35 ms 20.25 ms
11853e6 1220.37 ms 1252.83 ms 32.46 ms
c6c1cb7 1235.71 ms 1263.80 ms 28.08 ms
7bd90de 1233.48 ms 1249.47 ms 15.99 ms
b9ceffb 1222.57 ms 1247.96 ms 25.39 ms
2fc1ea5 1236.23 ms 1246.79 ms 10.56 ms
837f5e4 1231.20 ms 1265.47 ms 34.27 ms
cd9727b 1236.04 ms 1254.41 ms 18.37 ms
debf3e9 1227.45 ms 1235.71 ms 8.26 ms

App size

Revision Plain With Sentry Diff
ee1f2ca 24.15 KiB 1.01 MiB 1015.24 KiB
0759f32 23.75 KiB 880.20 KiB 856.46 KiB
11853e6 23.75 KiB 1.01 MiB 1016.04 KiB
c6c1cb7 23.75 KiB 928.15 KiB 904.40 KiB
7bd90de 23.75 KiB 933.33 KiB 909.58 KiB
b9ceffb 23.75 KiB 969.07 KiB 945.32 KiB
2fc1ea5 23.75 KiB 1.02 MiB 1016.53 KiB
837f5e4 23.75 KiB 1.01 MiB 1016.25 KiB
cd9727b 23.75 KiB 879.25 KiB 855.51 KiB
debf3e9 23.75 KiB 1.01 MiB 1006.46 KiB

Previous results on branch: itay/customizable_error_messages_user_feedback

Startup times

Revision Plain With Sentry Diff
0a4f9de 1226.93 ms 1257.07 ms 30.14 ms

App size

Revision Plain With Sentry Diff
0a4f9de 24.15 KiB 1.02 MiB 1016.05 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


## Unreleased

### Improvements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: That's actually a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add options to customize UserFeedback error messages feedback: user-facing string configurability audit

3 participants