-
-
Notifications
You must be signed in to change notification settings - Fork 372
Change the http.response.status_code for spans to int
#6896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Added to breaking changes, not sure if we should wait after 9.0.0, as this is marked for v10 in linear. |
❌ 2 Tests Failed:
View the top 2 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7bb24a2 | 1229.16 ms | 1256.66 ms | 27.50 ms |
| 2a7868a | 1226.54 ms | 1256.92 ms | 30.37 ms |
| 7b08a87 | 1220.14 ms | 1246.10 ms | 25.96 ms |
| 035974f | 1225.89 ms | 1251.23 ms | 25.34 ms |
| 2de3f92 | 1207.56 ms | 1234.96 ms | 27.40 ms |
| 705b962 | 1200.92 ms | 1222.04 ms | 21.13 ms |
| 42cfd79 | 1222.13 ms | 1244.23 ms | 22.10 ms |
| 25f2d2c | 1232.02 ms | 1242.78 ms | 10.76 ms |
| e8e40fd | 1222.10 ms | 1259.91 ms | 37.80 ms |
| 5c5648e | 1234.44 ms | 1253.79 ms | 19.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7bb24a2 | 23.75 KiB | 973.68 KiB | 949.93 KiB |
| 2a7868a | 23.75 KiB | 880.20 KiB | 856.45 KiB |
| 7b08a87 | 23.74 KiB | 913.70 KiB | 889.95 KiB |
| 035974f | 23.74 KiB | 874.07 KiB | 850.33 KiB |
| 2de3f92 | 23.75 KiB | 919.69 KiB | 895.94 KiB |
| 705b962 | 23.74 KiB | 995.47 KiB | 971.73 KiB |
| 42cfd79 | 23.75 KiB | 880.20 KiB | 856.45 KiB |
| 25f2d2c | 23.75 KiB | 866.69 KiB | 842.94 KiB |
| e8e40fd | 23.75 KiB | 1022.79 KiB | 999.04 KiB |
| 5c5648e | 23.75 KiB | 879.60 KiB | 855.86 KiB |
Previous results on branch: fix/int-for-http-status
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1fefafa | 1242.24 ms | 1253.32 ms | 11.07 ms |
| 0b972e4 | 1222.66 ms | 1259.29 ms | 36.63 ms |
| 2b30f77 | 1217.06 ms | 1250.73 ms | 33.67 ms |
| df46e67 | 1218.75 ms | 1246.72 ms | 27.97 ms |
| 2e40605 | 1227.63 ms | 1256.78 ms | 29.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1fefafa | 24.14 KiB | 1.01 MiB | 1013.53 KiB |
| 0b972e4 | 24.14 KiB | 1.01 MiB | 1015.51 KiB |
| 2b30f77 | 24.14 KiB | 1.01 MiB | 1013.53 KiB |
| df46e67 | 24.14 KiB | 1.01 MiB | 1012.68 KiB |
| 2e40605 | 24.14 KiB | 1.01 MiB | 1012.85 KiB |
|
@denrase this is a breaking change, we didn't think we have the time to do it for the v9 release so it was pushed back for v10 which won't happen for a while. As you already did it now, it makes sense to consider it for the next v9 RC |
philprime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a small breaking change. I think it's OK, as it's almost a bugfix actually. Thanks
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
📜 Description
💡 Motivation and Context
Closes #6327
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.