-
-
Notifications
You must be signed in to change notification settings - Fork 372
Remove extra log check #7027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra log check #7027
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7027 +/- ##
=============================================
+ Coverage 85.057% 85.077% +0.020%
=============================================
Files 454 454
Lines 27739 27737 -2
Branches 12162 12159 -3
=============================================
+ Hits 23594 23598 +4
+ Misses 4100 4092 -8
- Partials 45 47 +2
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
itaybre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 762a701 | 1225.95 ms | 1244.49 ms | 18.54 ms |
| 61414e8 | 1225.49 ms | 1254.28 ms | 28.79 ms |
| 588dd7c | 1235.11 ms | 1241.76 ms | 6.65 ms |
| f5666e7 | 1227.08 ms | 1260.18 ms | 33.10 ms |
| b9aacb6 | 1230.42 ms | 1251.00 ms | 20.58 ms |
| 16f6edc | 1234.02 ms | 1269.67 ms | 35.65 ms |
| b709887 | 1193.52 ms | 1216.74 ms | 23.22 ms |
| 5fc3364 | 1222.36 ms | 1252.33 ms | 29.96 ms |
| 1fe932f | 1231.92 ms | 1253.44 ms | 21.52 ms |
| 80538ca | 1216.70 ms | 1253.92 ms | 37.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 762a701 | 23.75 KiB | 1022.78 KiB | 999.03 KiB |
| 61414e8 | 23.75 KiB | 867.69 KiB | 843.94 KiB |
| 588dd7c | 23.75 KiB | 938.33 KiB | 914.58 KiB |
| f5666e7 | 23.75 KiB | 963.18 KiB | 939.43 KiB |
| b9aacb6 | 23.75 KiB | 913.64 KiB | 889.89 KiB |
| 16f6edc | 23.74 KiB | 1022.94 KiB | 999.19 KiB |
| b709887 | 23.75 KiB | 1.01 MiB | 1016.14 KiB |
| 5fc3364 | 23.75 KiB | 1.00 MiB | 1006.00 KiB |
| 1fe932f | 23.75 KiB | 913.63 KiB | 889.88 KiB |
| 80538ca | 23.75 KiB | 989.99 KiB | 966.24 KiB |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, LGTM.
I happened to notice these redundant log level checks, not necessary since it already calls
SENTRY_LOG_DEBUGwhich checks the log level#skip-changelog
Closes #7028