feat(scraps): Add documentation for SlideOverPanel
#102993
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
reviewed
Nov 8, 2025
| @@ -0,0 +1,38 @@ | |||
| --- | |||
Member
There was a problem hiding this comment.
Thank you @gggritso 🥇 Would you mind moving this inside a slideoverpanel folder and add an index.tsx with the exports? It's a convention we use for other files, and it avoids having to do import {SlideOverPanel} from '@sentry/scraps/slideoutpanel/slideoutpanel' which duplicates the component name
Member
Definitely need some TLC, but I think it's a good start. Since I know you've worked on the transition config, wdyt about just making that sprint transition be the default? I don't even think we need or want to allow people to change that in this instance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component has a bunch of use, including via
GlobalDrawerbut no Scraps story! I'm about to do some work with it (supporting deferred rendering, and overspring padding) and it's a lot easier to do that in Scraps.This felt like the right time to lift this component up in the folder hierarchy, too, and convert to a named export.
Does this component need any API changes or improvements before it's "official"? e.g.,
collapsedis awkward, passingclassNameIMO is awkward, and so onAll other feedback welcome