feat(aci): Track DataCondition errors and propagate such results as tainted #103003
+610
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #103003 +/- ##
===========================================
+ Coverage 80.58% 80.82% +0.23%
===========================================
Files 8937 8948 +11
Lines 391228 391894 +666
Branches 24887 24887
===========================================
+ Hits 315277 316746 +1469
+ Misses 75581 74778 -803
Partials 370 370 |
Member
Author
|
TODO: document how DataConditions should handle failure. |
| if condition_results is not None and condition_results.logic_result.is_tainted(): | ||
| tainted = True | ||
|
|
||
| if condition_results is None or condition_results.logic_result.triggered is False: |
Contributor
There was a problem hiding this comment.
Bug: Group Counter Resets Misdirected
enqueue_counter_reset() is called without passing group_key, causing it to reset counters for the default None group key instead of the current group being processed. This results in counter resets being applied to the wrong group when multiple groups are being evaluated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataCondition failures are currently reported to Sentry/logs individually, then treated as a non-triggering.
Here we return a special error type, so that the caller knows the result isn't necessarily reliable, and in DataConditionGroup logic we aggregate these results in such a way that we know at the end if an untrustworthy result influenced the outcome.
These "tainted" results are reported for each Detector evaluation, so we can track how often our results were influenced by errors, giving us a better high level picture of user impact than we'd have purely by looking at individual reported error counts.
This pattern will be extended to cover over DataCondition evaluation cases.