Interface-related type changes #1067
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior code used a type alias IfAddress = (IpAddr,u8). Instead, define a struct and add minimal validation. The new struct is called IfAddr instead of IfAddress to avoid confusion or the need to rename since the dplane-rpc has a type with that name. Signed-off-by: Fredi Raspall <[email protected]>
Signed-off-by: Fredi Raspall <[email protected]>
Change interfaces to use the SourceMac type to represent MACs. This avoids, among others, needing to convert from Mac to SourceMac for every packet that egresses the gateway. Signed-off-by: Fredi Raspall <[email protected]>
Fredi-raspall
requested review from
daniel-noland
and removed request for
a team
daniel-noland
requested changes
Nov 21, 2025
Collaborator
daniel-noland
left a comment
daniel-noland
left a comment
There was a problem hiding this comment.
Love the second two commits. The first commit only needs minor update. Thanks :D
| /// An Ipv4 or Ipv6 address and mask configured on an interface | ||
| pub type IfAddress = (IpAddr, u8); | ||
| #[derive(Debug, Clone, Copy, Eq, Hash, PartialEq)] | ||
| pub struct IfAddr { |
Collaborator
There was a problem hiding this comment.
Three concerns
- why put this in the routing package? Doesn't this belong in net?
- Shouldn't this be an enum with two differently validated types? One for ipv4 and one for ipv6?
- finally, the ip field should be scoped to unicast since you can't assign multicast addresses to interfaces (I suspect this will de-complicate downstream code as well)
| impl IfAddr { | ||
| /// Associated function that checks if an address or its mask | ||
| /// are legal to be configured on a network interface. | ||
| fn is_valid_ifaddr(address: IpAddr, mask_len: u8) -> Result<(), RouterError> { |
Collaborator
There was a problem hiding this comment.
you have rustdoc on a private function which won't be shown to most users. Better to put this (reworded) on new
| ////////////////////////////////////////////////////////////////// | ||
| pub fn del_ifaddr(&mut self, ifaddr: &IfAddress) { | ||
| self.addresses.remove(ifaddr); | ||
| pub fn del_ifaddr(&mut self, ifaddr: IfAddr) { |
Collaborator
There was a problem hiding this comment.
this observation is technically out of scope, but I don't see the point of hiding the return value here. Shouldn't we be able to detect that the address was in fact removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more changes to come that will be addressed in subsequent PRs.