activities by next jump#129
Closed
danse wants to merge 1 commit intoglguy:jump-monofrom
Closed
Conversation
Author
|
Anything wrong with this? Let me know how i can improve it |
Owner
|
I've pushed a change to have jump to activity advance forward so that you can mash alt-A and eventually see all your activity |
Author
|
I ditched my branch and am now using your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The performance cost of sorting rather than maximizing seems neglectable, and having windows in jump order improves the experience.
Extracting
windowListallowsjumpToActivityto be minimal and i took the chanche to simplify it, althoughm s slooks sus but had no ideas about how to improve it.