Skip to content

Conversation

@eduardomozart
Copy link
Contributor

@eduardomozart eduardomozart commented Feb 7, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes # (issue number, if applicable)
  • Here is a brief description of what this PR does

Screenshots (if appropriate):

The Agent port field was misaligned and the "General settings" page on mobile wasn't responsive.

Before this PR:

SCR-20250206-tzgb

After this PR:

image image

@eduardomozart eduardomozart changed the title Fix fields positioning on 'General settings' page Make the fields on 'General settings' page responsive Feb 7, 2025
@stonebuzz
Copy link
Collaborator

@eduardomozart

Can you please resolve the conflict?

Best regards

@eduardomozart
Copy link
Contributor Author

eduardomozart commented Nov 20, 2025

Hello @stonebuzz,
Thank you for taking your time to review this PR.
Conflict has been resolved and all checks have passed.
Please let me know if you need anything.
Regards.

@stonebuzz
Copy link
Collaborator

stonebuzz commented Nov 21, 2025

Hello @eduardomozart,

Thank you for the rebase. I’m not sure why GitHub is still showing conflicts.

Regarding the PR:

Main tab
The "Agent port" field is currently very large, especially on a 2K screen:

image

Network Inventory tab
The layout of the fields differs from the main tab.
Additionally, the content in both columns is right-aligned, which may affect readability.

Package Management tab
On a large screen (2K), the layout is not optimal—everything is aligned to the right:

image

@eduardomozart
Copy link
Contributor Author

Hello @stonebuzz,
Strange, for me, it shows as non-conflicts have been detected:

image

Originally, this PR applies only to the "General Settings" page. I'll take a look at this PR to fix your suggestions.

My only question is about the "Agent port" page. I do believe it happens because of Bootstrap dividing the page into two columns of col-6 width each, so I believe the view you're getting is expected. Do you have any GLPI reference page that the visual you would like the "Agent port" page to look like at 2K resolution?

@stonebuzz
Copy link
Collaborator

From my side ^^

image

@trasher
Copy link
Collaborator

trasher commented Nov 24, 2025

From my side ^^
image

Same here. But that sometimes happens, no idea why. I'll try to rebase on my side when PR will be finished; this is not a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants