Fix: JSONSlice stores "null" string instead of SQL NULL when nil#322
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Hi @dannyota Can you add some tests? |
Add a nil JSONSlice case to TestJSONSlice (persisted as SQL NULL, scans back as nil) and a nil Value() check to TestJSONTypeValueTypes, matching the existing JSONMap nil coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Add nil checks to JSONSlice
Value(),Scan(), andGormValue()— same pattern already used byJSON(json.go:25) andJSONMap(json_map.go:23) but missing fromJSONSlice.Without this fix, a nil
JSONSlicestores the literal string"null"instead of SQL NULL.User Case Description
Same issue as #99 but for
JSONSlice[T].Fixes #314