build: rm base_distro#120
Conversation
554ae28 to
67f77b3
Compare
67f77b3 to
edeb37a
Compare
|
I'm not fond of that change. The base distro defines a lot of the software we have available in the series of images, and while it's an approximation, it can usually be tied to a major update of these images. For example now I'm considering doing an update of all images based on Fedora 38 with newer toolchains. I still want to keep my existing images for comparison, and if they would both be named We could introduce an arbitrary version number, but so far relying on the base distro was good enough for the That being said I'm open to suggestions for how to better handle versioning. I'm not an expert on good docker practices, and while |
edeb37a to
a17f03b
Compare
On the one hand, the base distro is hardcoded in the Dockerfiles. On the other hand, there are not multiple variants of the images using different base distros. Moreover, these images are expected to used along with scripts from godot-build-scripts. Therefore, the base distro is not very relevant in the name. In any case, it should not be a CLI argument which is independent from the hardcoded value.