sdks/ts: fix serializer bugs and agentError null crash#2855
Merged
Conversation
- Fix missingObjectKey argument swap: arguments were reversed (tsValue, 'tag') → ('tag', tsValue)
- Fix handleObjectMatch null check: was comparing to string literal 'interface' instead of checking for null
- Fix u64 BigInt conversion: properly convert number to BigInt instead of casting as any
- Add null guards in serializeTsValueToBinaryReference and serializeTsValueToTextReference (typeof null === 'object' was passing the guard)
- Fix isAgentError crash on null input: add null/non-object guard before accessing properties
|
✅ All contributors have signed the CLA. |
This was referenced Mar 2, 2026
vigoo
approved these changes
Mar 5, 2026
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
missingObjectKeyargument swap: arguments were reversed(tsValue, 'tag')→('tag', tsValue), producing wrong error messageshandleObjectMatchnull check: was comparing to string literal'interface'instead of checking fornullanyserializeTsValueToBinaryReferenceandserializeTsValueToTextReference(typeof null === 'object'was passing the guard)isAgentErrorcrash onnullinput: add null/non-object guard before accessing propertiesContext
Split from #2845 — this PR contains only the bug fixes, no lint rule changes or type refactoring.
Test plan
isAgentError(null)returnsfalseinstead of crashingmissingObjectKeyerror messages