Clean up unnecessary codepaths from operator-run #9075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm investigating a bug from #9005, and discovered that many of these codepaths are rarely or never exercised by our tests, because there are just too many of them (and some of them are simply dead code). The probability of groups = 1 and batches = 1 in a randomized test is low, and when running on slow emulators, we don't get many chances. We also have different code for ARM vs. not-ARM (via `XNN_MAX_UARCH_TYPES`), which again forks our test coverage. I don't think these specializations are worth the cost (the constant vigilance required to ensure we don't lose test coverage of all of these paths). PiperOrigin-RevId: 826767227
copybara-service
bot
force-pushed
the
test_826767227
branch
from
0b991ca to
42dfe09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up unnecessary codepaths from operator-run
I'm investigating a bug from #9005, and discovered that many of these codepaths are rarely or never exercised by our tests, because there are just too many of them (and some of them are simply dead code). The probability of groups = 1 and batches = 1 in a randomized test is low, and when running on slow emulators, we don't get many chances. We also have different code for ARM vs. not-ARM (via
XNN_MAX_UARCH_TYPES), which again forks our test coverage.I don't think these specializations are worth the cost (the constant vigilance required to ensure we don't lose test coverage of all of these paths).